From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] SPI: OMAP: remove unnecessary includes of plat/clock.h
Date: Wed, 12 Sep 2012 10:58:04 +0530 [thread overview]
Message-ID: <50501D64.3030707@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209112330290.9444@utopia.booyaka.com>
On Wednesday 12 September 2012 05:01 AM, Paul Walmsley wrote:
> Remove unnecessary includes of plat/clock.h from the OMAP SPI
> controller drivers. These need to be removed to build multi-subarch
> ARM kernels which include these drivers.
Looks good to me
Acked-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/spi/spi-omap-100k.c | 2 --
> drivers/spi/spi-omap2-mcspi.c | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
> index 9bd1c92..dfb4b7f 100644
> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -37,8 +37,6 @@
>
> #include <linux/spi/spi.h>
>
> -#include <plat/clock.h>
> -
> #define OMAP1_SPI100K_MAX_FREQ 48000000
>
> #define ICR_SPITAS (OMAP7XX_ICR_BASE + 0x12)
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index b2fb141..b5d6994 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -41,7 +41,6 @@
>
> #include <linux/spi/spi.h>
>
> -#include <plat/clock.h>
> #include <plat/mcspi.h>
>
> #define OMAP2_MCSPI_MAX_FREQ 48000000
prev parent reply other threads:[~2012-09-12 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 23:31 [PATCH] SPI: OMAP: remove unnecessary includes of plat/clock.h Paul Walmsley
2012-09-12 5:28 ` Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50501D64.3030707@ti.com \
--to=shubhrajyoti@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).