From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH] spi/atmel: fix speed_hz check in atmel_spi_transfer() Date: Wed, 20 Feb 2013 08:51:48 +0100 Message-ID: <51248094.90808@atmel.com> References: <1361310297-28002-1-git-send-email-manabian@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Joachim Eastwood Return-path: In-Reply-To: <1361310297-28002-1-git-send-email-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 02/19/2013 10:44 PM, Joachim Eastwood : > atmel_spi_transfer() would check speed_hz and fail if > the speed was changed in the transfer. After commit > "spi: make sure all transfer has proper speed set" > this would happen on all transfers. > > Change speed_hz check to only fail if a lower speed > than max is requested. > > Signed-off-by: Joachim Eastwood Acked-by: Nicolas Ferre Thanks for spotting this Joachim. Bye, > --- > Hi Grant, > > Fix for spi-atmel as per your suggestion; check if > speed_hz is less than bus max speed. > > regards > Joachim Eastwood > > drivers/spi/spi-atmel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 656d137..80f5867 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -847,8 +847,8 @@ static int atmel_spi_transfer(struct spi_device *spi, struct spi_message *msg) > } > > /* FIXME implement these protocol options!! */ > - if (xfer->speed_hz) { > - dev_dbg(&spi->dev, "no protocol options yet\n"); > + if (xfer->speed_hz < spi->max_speed_hz) { > + dev_dbg(&spi->dev, "can't change speed in transfer\n"); > return -ENOPROTOOPT; > } > > -- Nicolas Ferre ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb