From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Cohen Subject: Re: [PATCH 1/2] spi: add Intel Mid SSP driver Date: Tue, 29 Oct 2013 12:32:28 -0700 Message-ID: <52700D4C.10008@linux.intel.com> References: <1383069950-27754-1-git-send-email-david.a.cohen@linux.intel.com> <1383070766.12439.13.camel@joe-AO722> <526FFED4.4070902@linux.intel.com> <1383071755.12439.17.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, ning.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fei Yang To: Joe Perches Return-path: In-Reply-To: <1383071755.12439.17.camel@joe-AO722> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 10/29/2013 11:35 AM, Joe Perches wrote: > On Tue, 2013-10-29 at 11:30 -0700, David Cohen wrote: >> Hi Joe, >> >> On 10/29/2013 11:19 AM, Joe Perches wrote: >>> On Tue, 2013-10-29 at 11:05 -0700, David Cohen wrote: >>>> This patch adds driver for ssp spi interface on Intel Mid platform. >>> >>> A few simple notes: >>> >>> Please consider using checkpatch. >> >> I did and got no warnings. But haven't used --strict option. > > Interesting. I thought there was a return (foo); > statement that should have been marked, but I didn't > actually run checkpatch. It seems odd checkpatch didn't catch it. I'll investigate. > > static inline u32 is_rx_fifo_empty(struct ssp_drv_context *sspc) > +{ > + return ((read_SSSR(sspc->ioaddr) & SSSR_RNE) == 0); > +} > > This could be bool too u32 seems unusual, but I'd prefer 'int' if it's fine for you. Br, David -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html