M25P80 Regulator Question

M25P80 Regulator Question

[Rhyland Klein]

I am looking at enabling support for W25Q32DW  SPI chip on a Tegra
platform. I found that the m25p80 driver already supports the chip, so
enabling it through devicetree is simple:


+       spi@7000da00 {
+               status = "okay";
+               spi-flash@0 {
+                       compatible = "winbond,w25q32dw";
+                       reg = <0>;
+                       spi-max-frequency = <20000000>;
+               };
+       };

However, it seems on our platform, we need to ensure a regulator is on
to be able to access the SPI chip. I was wondering if there is already
some binding defined for such a supply. I looked at the binding doc for
m25p80 and didn't see anything obvious, nor did I find anything else
obvious while looking.

Is there some mechanism for defining this dependency?

Thanks,
Rhyland

-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: M25P80 Regulator Question

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

On Fri, Nov 01, 2013 at 01:44:33PM -0400, Rhyland Klein wrote:

> Is there some mechanism for defining this dependency?

Same as any other device, add the regulator to the binding for the flash
chip and add the appropriate code to the chip.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: M25P80 Regulator Question

[Rhyland Klein]

On 11/1/2013 2:02 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
> 
> On Fri, Nov 01, 2013 at 01:44:33PM -0400, Rhyland Klein wrote:
> 
>> Is there some mechanism for defining this dependency?
> 
> Same as any other device, add the regulator to the binding for the flash
> chip and add the appropriate code to the chip.
> 
> * Unknown Key
> * 0x7EA229BD
> 

Thanks,

I just wanted to make sure I wasn't missing anything. I'll come up with
some patches. I believe there are patches in for optional regulator
support right, so I assume that would be the most logical path to take?

-rhyland

-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: M25P80 Regulator Question

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

On Fri, Nov 01, 2013 at 02:05:08PM -0400, Rhyland Klein wrote:

> I just wanted to make sure I wasn't missing anything. I'll come up with
> some patches. I believe there are patches in for optional regulator
> support right, so I assume that would be the most logical path to take?

No, you should not be using regulator_get_optional() - it is unlikely
that the flash device will work without power.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: M25P80 Regulator Question

[Rhyland Klein]

On 11/1/2013 2:16 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
> 
> On Fri, Nov 01, 2013 at 02:05:08PM -0400, Rhyland Klein wrote:
> 
>> I just wanted to make sure I wasn't missing anything. I'll come up with
>> some patches. I believe there are patches in for optional regulator
>> support right, so I assume that would be the most logical path to take?
> 
> No, you should not be using regulator_get_optional() - it is unlikely
> that the flash device will work without power.
> 
> * Unknown Key
> * 0x7EA229BD
> 
Alright, thanks!!


-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html