From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [patch] spi: tegra: checking for ERR_PTR instead of NULL Date: Mon, 16 Dec 2013 09:55:47 -0700 Message-ID: <52AF3093.30308@wwwdotorg.org> References: <20131216140210.GA32033@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Mark Brown , Thierry Reding , linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter , Laxman Dewangan Return-path: In-Reply-To: <20131216140210.GA32033@elgon.mountain> Sender: kernel-janitors-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On 12/16/2013 07:02 AM, Dan Carpenter wrote: > dma_request_slave_channel() returns NULL on error and not ERR_PTRs. > I've fixed this by using dma_request_slave_channel_reason() which does > return ERR_PTRs. > > Fixes: a915d150f68d ('spi: tegra: convert to standard DMA DT bindings') > Signed-off-by: Dan Carpenter Oops. I validate there aren't any more issues like this, at least in the commits in the series this fixes. I've applied this to Tegra's for-3.14/dmas-resets-rework branch, since that's the only place where the commit this fixes exists.