From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] spi: Check conflicting CS based on spi->chip_select instead of device name Date: Thu, 09 Jan 2014 15:59:38 +0200 Message-ID: <52CEAB4A.605@linux.intel.com> References: <1389273835-8615-1-git-send-email-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mika Westerberg Return-path: In-Reply-To: <1389273835-8615-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 01/09/2014 03:23 PM, Mika Westerberg wrote: > Commit e13ac47bec20 (spi: Use stable dev_name for ACPI enumerated SPI > slaves) changed the SPI device naming to be based on ACPI device name > instead of carrying bus number and chip select for devices enumerated > from ACPI namespace. > > In case of a buggy BIOS that lists multiple SPI devices sharing the same > chip select (even though they should use different) the current code fails > to detect that and allows the devices to be added to the bus. > > Fix this by walking through the bus and comparing spi->chip_select instead > of device name. This should work regardless what the device name will be in > future. > > Cc: Jarkko Nikula > Signed-off-by: Mika Westerberg > --- > drivers/spi/spi.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 349ebba4b199..13dcc360bde6 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > I guess this is a valid fix in that sense that before my patch those ill-defined SPI devices were not added. Is this something which should go to 3.13? Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html