* [RFC][PATCH] spi: ti-qspi: Fixup driver name
@ 2014-01-12 7:02 Axel Lin
2014-01-12 8:26 ` sourav
2014-01-13 10:16 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-01-12 7:02 UTC (permalink / raw)
To: Mark Brown; +Cc: Sourav Poddar, linux-spi-u79uwXL29TY76Z2rM5mHXA
The driver name in current code looks like a compatible string which is not
the naming convention for platform drivers.
Fix it and also add modalias since this driver can be built as a module.
Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
drivers/spi/spi-ti-qspi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 2a1ab49..3d09265 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -567,7 +567,7 @@ static struct platform_driver ti_qspi_driver = {
.probe = ti_qspi_probe,
.remove = ti_qspi_remove,
.driver = {
- .name = "ti,dra7xxx-qspi",
+ .name = "ti-qspi",
.owner = THIS_MODULE,
.pm = &ti_qspi_pm_ops,
.of_match_table = ti_qspi_match,
@@ -579,3 +579,4 @@ module_platform_driver(ti_qspi_driver);
MODULE_AUTHOR("Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>");
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("TI QSPI controller driver");
+MODULE_ALIAS("platform:ti-qspi");
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC][PATCH] spi: ti-qspi: Fixup driver name
2014-01-12 7:02 [RFC][PATCH] spi: ti-qspi: Fixup driver name Axel Lin
@ 2014-01-12 8:26 ` sourav
2014-01-13 10:16 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: sourav @ 2014-01-12 8:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA
On Sunday 12 January 2014 12:32 PM, Axel Lin wrote:
> The driver name in current code looks like a compatible string which is not
> the naming convention for platform drivers.
> Fix it and also add modalias since this driver can be built as a module.
>
> Signed-off-by: Axel Lin<axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/spi/spi-ti-qspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index 2a1ab49..3d09265 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -567,7 +567,7 @@ static struct platform_driver ti_qspi_driver = {
> .probe = ti_qspi_probe,
> .remove = ti_qspi_remove,
> .driver = {
> - .name = "ti,dra7xxx-qspi",
> + .name = "ti-qspi",
> .owner = THIS_MODULE,
> .pm =&ti_qspi_pm_ops,
> .of_match_table = ti_qspi_match,
> @@ -579,3 +579,4 @@ module_platform_driver(ti_qspi_driver);
> MODULE_AUTHOR("Sourav Poddar<sourav.poddar-l0cyMroinI0@public.gmane.org>");
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("TI QSPI controller driver");
> +MODULE_ALIAS("platform:ti-qspi");
Acked-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC][PATCH] spi: ti-qspi: Fixup driver name
2014-01-12 7:02 [RFC][PATCH] spi: ti-qspi: Fixup driver name Axel Lin
2014-01-12 8:26 ` sourav
@ 2014-01-13 10:16 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-01-13 10:16 UTC (permalink / raw)
To: Axel Lin; +Cc: Sourav Poddar, linux-spi-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
On Sun, Jan 12, 2014 at 03:02:32PM +0800, Axel Lin wrote:
> The driver name in current code looks like a compatible string which is not
> the naming convention for platform drivers.
> Fix it and also add modalias since this driver can be built as a module.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 7:02 [RFC][PATCH] spi: ti-qspi: Fixup driver name Axel Lin
2014-01-12 8:26 ` sourav
2014-01-13 10:16 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).