From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH V2 6/8] spi: rspi: Add support for missing SPCR2 register Date: Mon, 13 Jan 2014 16:36:43 +0400 Message-ID: <52D3DDDB.309@cogentembedded.com> References: <1389522464-1569-1-git-send-email-geert@linux-m68k.org> <1389522464-1569-7-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Geert Uytterhoeven To: Geert Uytterhoeven , Mark Brown Return-path: In-Reply-To: <1389522464-1569-7-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hello. On 12-01-2014 14:27, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > Add support for RSPI variants lacking the RSPI Control Register 2, based on > the SDK reference code. This is needed for RZ/A1H. > The availability of this register is passed using platform data, defaulting > to true for legacy RSPI. QSPI never has this register. > If the register is not available, it should not be touched. > Signed-off-by: Geert Uytterhoeven > Acked-by: Laurent Pinchart I believe such things should be done via different platform device IDs instead, not platform data. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html