From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: "Chen, Alvin" <alvin.chen@intel.com>,
Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"Tan, Raymond" <raymond.tan@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000
Date: Wed, 08 Oct 2014 10:02:07 +0100 [thread overview]
Message-ID: <5434FD8F.8090209@nexus-software.ie> (raw)
In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E997E59@SHSMSX101.ccr.corp.intel.com>
On 08/10/14 08:48, Chen, Alvin wrote:
> Now, we have another board which can support 4 slave spi per master, but not only Galileo. Since that board is not public, after discussing with team, we decide to make the
> upstream code to support '1'.
>
> I will change it back to
> .num_chipselect = 1,
Hi Alvin.
The important thing in terms of Galileo is to ensure that a GPIO can be
used for chip-select.
The user-space API ported from Arduino to Linux wants to control it's
own chip-select directly - so the internal chip-select of the Quark SPI
master can - and does de-assert while doing SPI transactions on Galileo.
The CS on the master is tied to FIFO occupancy - so at higher bit-rates
we can fail to keep the FIFO occupied :(
That doesn't matter though, because the pinned out SPI:CS on the Arduino
header is a GPIO.
From the perspective of the Arduino code in user-space and the slave
hardware @ the other end of the SPI bus - we see a nice and consistent
chip-select for the entire duration of the SPI transaction - even though
the actual SPI:CS coming from the SoC can *waggle* - when FIFOs go empty.
IMO - so long as you've tested on Galileo and seen working SPI - you're
good to go anyway.
Bryan
next prev parent reply other threads:[~2014-10-08 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 14:22 [PATCH 0/2 v2] SPI: spi-pxa2xx: Add support for Intel Quark X1000 SPI controller Weike Chen
2014-09-29 14:22 ` [PATCH 1/2 v2] SPI: spi-pxa2xx: Add helpers for regiseters' accessing Weike Chen
[not found] ` <1412000548-9908-2-git-send-email-alvin.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 8:52 ` Andy Shevchenko
[not found] ` <1411980737.10697.0.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-10-08 0:46 ` Chen, Alvin
2014-09-29 9:53 ` Mika Westerberg
2014-09-29 14:22 ` [PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000 Weike Chen
2014-09-29 9:57 ` Mika Westerberg
2014-10-08 1:03 ` Bryan O'Donoghue
[not found] ` <54348D56.20708-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
2014-10-08 7:48 ` Chen, Alvin
2014-10-08 9:02 ` Bryan O'Donoghue [this message]
[not found] ` <1412000548-9908-3-git-send-email-alvin.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 9:02 ` Andy Shevchenko
2014-10-08 1:32 ` Chen, Alvin
2014-11-25 20:06 ` Olof Johansson
[not found] ` <CAOesGMi5f_Kc1xA_JqiZYsbVYxaJgBXMZCe5TAxDkPQj7=o8sg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-25 21:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5434FD8F.8090209@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=alvin.chen@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boon.leong.ong@intel.com \
--cc=broonie@kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mika.westerberg@intel.com \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).