From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH] spi: spi-fsl-spi: Return an error code in fsl_spi_do_one_msg() Date: Thu, 04 Dec 2014 19:18:22 +0100 Message-ID: <5480A56E.8050308@gmail.com> References: <1417698947-4273-1-git-send-email-fabio.estevam@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Mark Brown , "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Fabio Estevam Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Am 04.12.2014 um 15:12 schrieb Fabio Estevam: > On Thu, Dec 4, 2014 at 11:25 AM, Heiner Kallweit wrote: >> Right, missed that. However the code was bogus before, the status = -EINVAL >> didn't make sense as the value of variable status isn't used before the >> return. >> Therefore we can remove the "status = -EINVAL". > > Yes, I noticed that as well. > >> Shall I submit a patch or what would be your preferred approach? > > Yes, may be it would be better if you could submit a fix for this as > separate patch, after Mark applies this one, so that we avoid > conflicts. > OK, just submitted the fix as a separate patch. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html