From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH/RFC] spi: sh-msiof: Add runtime PM lock in initializing Date: Mon, 15 Dec 2014 21:19:59 +0300 Message-ID: <548F264F.5000901@cogentembedded.com> References: <1418652071-6396-1-git-send-email-ykaneko0929@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark Brown , Simon Horman , Magnus Damm , Geert Uytterhoeven , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yoshihiro Kaneko , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <1418652071-6396-1-git-send-email-ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hello. On 12/15/2014 05:01 PM, Yoshihiro Kaneko wrote: > From: Hisashi Nakamura > SH-MSIOF driver is enabled autosuspend API of spi framework. > But autosuspend framework doesn't work during initializing. > So runtime PM lock is added in SH-MSIOF driver initializing. > Signed-off-by: Hisashi Nakamura > Signed-off-by: Yoshihiro Kaneko > --- > This patch is based on the for-next branch of Mark Brown's spi tree. > drivers/spi/spi-sh-msiof.c | 5 +++++ > 1 file changed, 5 insertions(+) > diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c > index 3f36540..1405293 100644 > --- a/drivers/spi/spi-sh-msiof.c > +++ b/drivers/spi/spi-sh-msiof.c [...] > @@ -498,6 +500,9 @@ static int sh_msiof_spi_setup(struct spi_device *spi) > if (spi->cs_gpio >= 0) > gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH)); > > + > + pm_runtime_put_sync(&p->pdev->dev); > + Do you really need the sync version here? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html