From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nobuhiro Iwamatsu Subject: Re: [PATCH v2] spi: sh-msiof: Update calculation of frequency dividing Date: Fri, 30 Jan 2015 15:13:53 +0900 Message-ID: <54CB2121.4000607@renesas.com> References: <1421286613-8240-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-spi , Linux-sh list , Sergei Shtylyov , Yoshihiro Shimoda To: Geert Uytterhoeven Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org Hi, (2015/01/15 23:21), Geert Uytterhoeven wrote: > Hi Iwamatsu-san, > > Thanks for the update! > > On Thu, Jan 15, 2015 at 2:50 AM, Nobuhiro Iwamatsu > wrote: >> @@ -804,7 +803,9 @@ static int sh_msiof_transfer_one(struct spi_master *master, >> int ret; >> >> /* setup clocks (clock already enabled in chipselect()) */ >> - sh_msiof_spi_set_clk_regs(p, clk_get_rate(p->clk), t->speed_hz); >> + ret = sh_msiof_spi_set_clk_regs(p, clk_get_rate(p->clk), t->speed_hz); >> + if (ret) >> + return ret; > > I think this can be handled by the core, if we fill in spi_master.min_speed_hz. I see. I removed this change. > > BTW, you should also CC Mark Brown when sending SPI patches. OK, I will add him form next patch. > > Gr{oetje,eeting}s, > > Geert Best regards, Nobuhiro > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds