* [PATCH 3/4] spi: pl022: Remove dead code
@ 2015-02-27 15:30 Alexander Sverdlin
[not found] ` <54F08D87.5060604-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Sverdlin @ 2015-02-27 15:30 UTC (permalink / raw)
To: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA, Linus Walleij
spi: pl022: Remove dead code
"flag" variable does nothing, remove it.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi-pl022.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 0566657..ad78766 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -1230,7 +1230,6 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id)
struct pl022 *pl022 = dev_id;
struct spi_message *msg = pl022->cur_msg;
u16 irq_status = 0;
- u16 flag = 0;
if (unlikely(!msg)) {
dev_err(&pl022->adev->dev,
@@ -1279,8 +1278,7 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id)
readwriter(pl022);
- if ((pl022->tx == pl022->tx_end) && (flag == 0)) {
- flag = 1;
+ if (pl022->tx == pl022->tx_end) {
/* Disable Transmit interrupt, enable receive interrupt */
writew((readw(SSP_IMSC(pl022->virtbase)) &
~SSP_IMSC_MASK_TXIM) | SSP_IMSC_MASK_RXIM,
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] spi: pl022: Remove dead code
[not found] ` <54F08D87.5060604-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
@ 2015-03-06 19:45 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-03-06 19:45 UTC (permalink / raw)
To: Alexander Sverdlin; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
On Fri, Feb 27, 2015 at 04:30:15PM +0100, Alexander Sverdlin wrote:
> spi: pl022: Remove dead code
>
> "flag" variable does nothing, remove it.
applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-06 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 15:30 [PATCH 3/4] spi: pl022: Remove dead code Alexander Sverdlin
[not found] ` <54F08D87.5060604-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-03-06 19:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).