From: Lars-Peter Clausen <lars@metafoo.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-spi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Andy Gross <agross@codeaurora.org>,
Sagar Dharia <sdharia@codeaurora.org>,
Daniel Sneddon <dsneddon@codeaurora.org>
Subject: Re: [PATCH v4] spi: qup: Add DMA capabilities
Date: Mon, 09 Mar 2015 10:12:49 +0100 [thread overview]
Message-ID: <54FD6411.90401@metafoo.de> (raw)
In-Reply-To: <CAHp75Vd7+GxT01+X5u4n=tXdBu-gcmdS-AETu0yK6PWFfjzDEA@mail.gmail.com>
On 03/08/2015 01:20 PM, Andy Shevchenko wrote:
> On Sun, Mar 8, 2015 at 1:21 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> On 03/07/2015 08:43 PM, Andy Shevchenko wrote:
>>>
>>> On Sat, Mar 7, 2015 at 1:21 PM, Mark Brown <broonie@kernel.org> wrote:
>
>>>> Applied, but why is there no devm_dma_request_slave_channel_reason()?
>>>
>>> I suppose the answer would be "we have a lot of slightly different
>>> cases and we have to get rid of current mess with legacy API calls".
>>> The most problematic stuff now inside DMA slave subsystem is so called
>>> "filter function". It's a main impediment right now as I understand.
>>
>> dma_request_slave_channel_reason() is the sane API though and does not use
>> the filter functions. Adding a devm version of it seems reasonable.
>
> It would be dma_request_slave_channel() in the first place, but legacy
> stuff didn't allow to do that, so here we are. I wouldn't like the
> idea of creating devm_dma_* before we will have stable function names
> without legacy involving.
>
At some point when all callers dma_request_slave_channel() have been updated
to use dma_request_slave_channel_reason(), the later might be renamed to the
former. I don't see the problem with having to do the same for a
devm_dma_request_slave_channel_reason().
- Lars
prev parent reply other threads:[~2015-03-09 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 10:02 [PATCH v4] spi: qup: Add DMA capabilities Stanimir Varbanov
2015-03-06 14:38 ` Ivan T. Ivanov
2015-03-07 11:21 ` Mark Brown
2015-03-07 19:43 ` Andy Shevchenko
[not found] ` <CAHp75VeYanNJrEyTtcxb5g5DB8=609nebgZm8zVAeJdmSgHjkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-08 11:21 ` Lars-Peter Clausen
2015-03-08 12:20 ` Andy Shevchenko
2015-03-09 9:12 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD6411.90401@metafoo.de \
--to=lars@metafoo.de \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsneddon@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).