* [PATCH 09/13] spi: atmel: use endian agnostic IO [not found] ` <1426693992-31163-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> @ 2015-03-18 15:53 ` Ben Dooks [not found] ` <1426693992-31163-10-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Ben Dooks @ 2015-03-18 15:53 UTC (permalink / raw) To: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: Ben Dooks, Nicolas Ferre, Mark Brown, open list:SPI SUBSYSTEM Use the endian agnositc IO functions instead of the __raw ones for when the driver is in use on big-endian systems. Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> -- CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> (supporter:ATMEL SPI DRIVER) CC: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> (maintainer:SPI SUBSYSTEM) CC: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:SPI SUBSYSTEM) --- drivers/spi/spi-atmel.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 06de340..a2f40b1 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -180,11 +180,17 @@ | SPI_BF(name, value)) /* Register access macros */ +#ifdef CONFIG_AVR32 #define spi_readl(port, reg) \ __raw_readl((port)->regs + SPI_##reg) #define spi_writel(port, reg, value) \ __raw_writel((value), (port)->regs + SPI_##reg) - +#else +#define spi_readl(port, reg) \ + readl_relaxed((port)->regs + SPI_##reg) +#define spi_writel(port, reg, value) \ + writel_relaxed((value), (port)->regs + SPI_##reg) +#endif /* use PIO for small transfers, avoiding DMA setup/teardown overhead and * cache operations; better heuristics consider wordsize and bitrate. */ -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1426693992-31163-10-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>]
* Re: [PATCH 09/13] spi: atmel: use endian agnostic IO [not found] ` <1426693992-31163-10-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> @ 2015-03-19 0:56 ` Mark Brown 2015-03-19 8:53 ` Nicolas Ferre 2015-03-22 18:01 ` Mark Brown 2 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2015-03-19 0:56 UTC (permalink / raw) To: Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Nicolas Ferre, open list:SPI SUBSYSTEM [-- Attachment #1: Type: text/plain, Size: 408 bytes --] On Wed, Mar 18, 2015 at 03:53:08PM +0000, Ben Dooks wrote: > Use the endian agnositc IO functions instead of the __raw ones for when > the driver is in use on big-endian systems. > > Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> I'm not CCed on either the cover letter or the rest of the series: are there any dependencies here or is it safe to apply this by itself? [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/13] spi: atmel: use endian agnostic IO [not found] ` <1426693992-31163-10-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-19 0:56 ` Mark Brown @ 2015-03-19 8:53 ` Nicolas Ferre 2015-03-22 18:01 ` Mark Brown 2 siblings, 0 replies; 4+ messages in thread From: Nicolas Ferre @ 2015-03-19 8:53 UTC (permalink / raw) To: Ben Dooks, Mark Brown Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, SPI SUBSYSTEM, Alexandre Belloni, Yang, Wenyou Le 18/03/2015 16:53, Ben Dooks a écrit : > Use the endian agnositc IO functions instead of the __raw ones for when > the driver is in use on big-endian systems. > > Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> Looks good to me: Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Mark, There is no dependency on the series, so you can take this one right now. Bye. > -- > CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> (supporter:ATMEL SPI DRIVER) > CC: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> (maintainer:SPI SUBSYSTEM) > CC: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:SPI SUBSYSTEM) > --- > drivers/spi/spi-atmel.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 06de340..a2f40b1 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -180,11 +180,17 @@ > | SPI_BF(name, value)) > > /* Register access macros */ > +#ifdef CONFIG_AVR32 > #define spi_readl(port, reg) \ > __raw_readl((port)->regs + SPI_##reg) > #define spi_writel(port, reg, value) \ > __raw_writel((value), (port)->regs + SPI_##reg) > - > +#else > +#define spi_readl(port, reg) \ > + readl_relaxed((port)->regs + SPI_##reg) > +#define spi_writel(port, reg, value) \ > + writel_relaxed((value), (port)->regs + SPI_##reg) > +#endif > /* use PIO for small transfers, avoiding DMA setup/teardown overhead and > * cache operations; better heuristics consider wordsize and bitrate. > */ > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/13] spi: atmel: use endian agnostic IO [not found] ` <1426693992-31163-10-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-19 0:56 ` Mark Brown 2015-03-19 8:53 ` Nicolas Ferre @ 2015-03-22 18:01 ` Mark Brown 2 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2015-03-22 18:01 UTC (permalink / raw) To: Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Nicolas Ferre, open list:SPI SUBSYSTEM [-- Attachment #1: Type: text/plain, Size: 664 bytes --] On Wed, Mar 18, 2015 at 03:53:08PM +0000, Ben Dooks wrote: > Use the endian agnositc IO functions instead of the __raw ones for when > the driver is in use on big-endian systems. > > Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> > -- > CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> (supporter:ATMEL SPI DRIVER) > CC: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> (maintainer:SPI SUBSYSTEM) > CC: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:SPI SUBSYSTEM) Applied, thanks. If you don't want things to go into the message then they should be after --- not --. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-22 18:01 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk> [not found] ` <1426693992-31163-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-18 15:53 ` [PATCH 09/13] spi: atmel: use endian agnostic IO Ben Dooks [not found] ` <1426693992-31163-10-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-19 0:56 ` Mark Brown 2015-03-19 8:53 ` Nicolas Ferre 2015-03-22 18:01 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).