From: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] spi: spidev: Warn loudly if instantiated from DT as "spidev"
Date: Thu, 23 Apr 2015 15:21:26 +0200 [thread overview]
Message-ID: <5538F1D6.7020503@martin.sperl.org> (raw)
In-Reply-To: <20150423103652.GT22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 2015-04-23 12:36, Mark Brown wrote:
> On Thu, Apr 23, 2015 at 09:45:16AM +0200, Geert Uytterhoeven wrote:
>
>> I guess this has been suggested before: the spi core could provide spidev
>> access to all spi client devices which are not bound by a driver?
>
> I don't know if it's been suggested before, certainly nobody did the
> work to make it happen. I don't think I have a massive objection in
> principal.
>
Maybe until that is fixed keep the warning message but remove the
WARN_ON(...), which is responsible for the 50+ lines in dmesg which
looks like a major issue because of the full stack-trace produced
and not just a "simple" warning...
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-23 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 23:42 [PATCH] spi: spidev: Warn loudly if instantiated from DT as "spidev" Mark Brown
[not found] ` <1427499742-26916-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-04-23 7:21 ` Martin Sperl
[not found] ` <7C2BEBF5-5169-4804-A7B8-DBCE2E9E8C70-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-04-23 7:42 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUv0z=VOec+JbbRBeM9fg2TvQgRX4GefVbOZDoQoOECQQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-23 7:45 ` Geert Uytterhoeven
[not found] ` <CAMuHMdW5hgB7vFmMc6TRqJ2wwWZ0=S+OKdQQoucXakoSnVixtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-23 10:36 ` Mark Brown
[not found] ` <20150423103652.GT22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-23 13:21 ` Martin Sperl [this message]
[not found] ` <5538F1D6.7020503-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-04-23 13:36 ` Mark Brown
[not found] ` <5538F95A.20203@martin.sperl.org>
[not found] ` <20150423181317.GZ22845@sirena.org.uk>
[not found] ` <20150423181317.GZ22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-23 19:23 ` Martin Sperl
[not found] ` <81BCB930-E90B-4978-9593-7997B64F65CE@martin.sperl.org>
[not found] ` <81BCB930-E90B-4978-9593-7997B64F65CE-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-04-23 19:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538F1D6.7020503@martin.sperl.org \
--to=kernel-tqfnsx0mhmxhksadf0wuew@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).