From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/3] spi: Re-do the returning value of rspi_dma_check_then_transfer Date: Tue, 28 Apr 2015 14:45:53 +0300 Message-ID: <553F72F1.9010300@cogentembedded.com> References: <1430200551-20708-1-git-send-email-cm-hiep@jinso.co.jp> <1430200551-20708-2-git-send-email-cm-hiep@jinso.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, ryusuke.sakato.bx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Cao Minh Hiep , geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org Return-path: In-Reply-To: <1430200551-20708-2-git-send-email-cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hello. On 4/28/2015 8:55 AM, Cao Minh Hiep wrote: > From: Hiep Cao Minh > To reduce indentation and complex of code, insteeds of returning zero, Complexity? > the function rspi_dma_check_then_transfer should be returned Returning? Or perhaps just "return", without "be"? > rspi_dma_transfer directly after checking error. > Signed-off-by: Hiep Cao Minh > --- > drivers/spi/spi-rspi.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html