linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: expose spi_master and spi_device statistics via sysfs
Date: Wed, 03 Jun 2015 13:25:58 +0200	[thread overview]
Message-ID: <556EE446.3060407@metafoo.de> (raw)
In-Reply-To: <1432574909-2326-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>

On 05/25/2015 07:28 PM, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
> From: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
>
> per spi-master statistics accessible as:
>    /sys/class/spi_master/spi*/statistics/
>
> per spi-device statistics accessible via:
>    /sys/class/spi_master/spi*/spi*.*/statistics/
>
> The following statistics are exposed as separate "files" inside
> these directories:
>    * messages		number of spi_messages
>    * transfers		number of spi_transfers
>    * bytes		number of bytes transferred
>    * bytes_rx		number of bytes transmitted
>    * bytes_tx		number of bytes received
>    * bytes_histo		transferred bytes/spi_transfer histogram

Having those kinds of stats in world readable files has serious security 
implications as they can be used to implement side-channel attacks. They 
should probably only be available in debugfs for root.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-06-03 11:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 17:28 [PATCH] spi: expose spi_master and spi_device statistics via sysfs kernel-TqfNSX0MhmxHKSADF0wUEw
     [not found] ` <1432574909-2326-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-06-02 20:02   ` Mark Brown
2015-06-03 11:25   ` Lars-Peter Clausen [this message]
     [not found]     ` <556EE446.3060407-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-06-03 11:53       ` Mark Brown
     [not found]         ` <20150603115319.GF14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-04 16:56           ` Martin Sperl
     [not found]             ` <8DBE5E2D-47ED-48D3-A185-82AF4831B0A2-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-06-18 12:54               ` Martin Sperl
     [not found]                 ` <B3BA7701-96E1-466A-90EA-121E2A85F851-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-06-18 13:49                   ` Mark Brown
     [not found]                     ` <20150618134918.GF14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-19  9:35                       ` Jakub Kiciński
2015-06-19  9:53                         ` Mark Brown
     [not found]                           ` <20150619095346.GG14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-19 10:02                             ` Martin Sperl
     [not found]                               ` <394B0003-AA2E-469F-AD9C-C291FAC60A94-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-06-19 10:10                                 ` Mark Brown
     [not found]                                   ` <20150619101046.GH14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-20 12:10                                     ` Geert Uytterhoeven
     [not found]                                       ` <CAMuHMdUpGgQRD=pwywDE=nKK8p3CQoFFuRZduvXkttmc0dfRTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-20 15:24                                         ` Martin Sperl
2015-06-19  9:51                       ` Jakub Kiciński
2015-06-19  9:56                       ` Jakub Kiciński
2015-06-19 10:00                         ` Jakub Kiciński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556EE446.3060407@metafoo.de \
    --to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).