From: Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/3] spi: fsl-(e)spi: simplify cleanup code
Date: Tue, 25 Aug 2015 22:19:35 +0200 [thread overview]
Message-ID: <55DCCDD7.5030307@gmail.com> (raw)
In-Reply-To: <20150825174508.GF12878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Am 25.08.2015 um 19:45 schrieb Mark Brown:
> On Sun, Aug 23, 2015 at 02:21:53PM +0200, Heiner Kallweit wrote:
>
>> static int of_fsl_espi_remove(struct platform_device *dev)
>> {
>> - return mpc8xxx_spi_remove(&dev->dev);
>> + return 0;
>> }
>
> You should be able to remove empty functions like this one.
In patch 3 a call to pm_runtime_disable is added to this function.
Therefore I don't remove it in patch 2. Fine with you?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-25 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 12:21 [PATCH 2/3] spi: fsl-(e)spi: simplify cleanup code Heiner Kallweit
[not found] ` <55D9BAE1.1030306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-25 17:45 ` Mark Brown
[not found] ` <20150825174508.GF12878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-25 20:19 ` Heiner Kallweit [this message]
[not found] ` <55DCCDD7.5030307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-26 10:58 ` Mark Brown
[not found] ` <20150826105857.GQ12878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-26 17:56 ` Heiner Kallweit
2015-08-26 18:14 ` Heiner Kallweit
[not found] ` <55DE01FF.3000607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-26 18:45 ` Mark Brown
[not found] ` <20150826184506.GF28760-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-26 18:54 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DCCDD7.5030307@gmail.com \
--to=hkallweit1-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).