Re: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c

Re: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c

[Jarkko Nikula]

Hi

Adding linux-spi and Mark Brown.

On 09/01/2015 05:04 AM, Axel Lin wrote:
>    CC [M]  arch/arm/plat-pxa/ssp.o
> arch/arm/plat-pxa/ssp.c:110:52: error: 'LPSS_SSP' undeclared here (not in a function)
> scripts/Makefile.build:264: recipe for target 'arch/arm/plat-pxa/ssp.o' failed
> make[1]: *** [arch/arm/plat-pxa/ssp.o] Error 1
> Makefile:965: recipe for target 'arch/arm/plat-pxa' failed
> make: *** [arch/arm/plat-pxa] Error 2
>
>
> The build error is introduced by:
> commit 03fbf488cece461468d3abb795f5e5f055e00040
> Author: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Date:   Thu Jun 4 16:55:10 2015 +0300
>
>      spi: pxa2xx: Differentiate Intel LPSS types
>
I obviously didn't do tree wide grep for LPSS_SSP and pxa3xx_defconfig 
don't reveal it without setting CONFIG_USE_OF. Sorry about that.

No I'm pondering how to fix this. I see these bindings are added by the 
commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") but some of the 
types are not used anywhere. For instance PXA168_SSP or PXA910_SSP. Then 
PXA3xx_SSP is used in sound/soc/pxa/pxa-ssp.c and CE4100_SSP in 
drivers/spi/spi-pxa2xx.c (where LPSS_SSP was used too before 
differentiating it).

What I'm wondering is this binding below correct in 
arch/arm/plat-pxa/ssp.c? LPSS_SSP was meant to be for Intel Intel Low 
Power Subsystem SPI.

"{ .compatible = "mrvl,lpss-ssp",	.data = (void *) LPSS_SSP }"

Mika, Daniel: do you know is there any change there is a Marvell PXA 
platform compatible with Intel LPSS or is above binding bogus?

-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

On Tue, Sep 01, 2015 at 09:36:04AM +0300, Jarkko Nikula wrote:

> No I'm pondering how to fix this. I see these bindings are added by the
> commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") but some of the types
> are not used anywhere. For instance PXA168_SSP or PXA910_SSP. Then
> PXA3xx_SSP is used in sound/soc/pxa/pxa-ssp.c and CE4100_SSP in
> drivers/spi/spi-pxa2xx.c (where LPSS_SSP was used too before differentiating
> it).

IIRC the PXA168 and PXA910 are software compatible with the PXA3xx SPI
controller.  Those SoCs never got wide distribution compared to the
older PXA models I think.

> What I'm wondering is this binding below correct in arch/arm/plat-pxa/ssp.c?
> LPSS_SSP was meant to be for Intel Intel Low Power Subsystem SPI.

> "{ .compatible = "mrvl,lpss-ssp",	.data = (void *) LPSS_SSP }"

> Mika, Daniel: do you know is there any change there is a Marvell PXA
> platform compatible with Intel LPSS or is above binding bogus?

I bet it's just cut'n'paste because everything else about the driver and
all the DT is for Marvell stuff.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c

[Axel Lin]

2015-09-02 2:43 GMT+08:00 Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> On Tue, Sep 01, 2015 at 09:36:04AM +0300, Jarkko Nikula wrote:
>
>> No I'm pondering how to fix this. I see these bindings are added by the
>> commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") but some of the types
>> are not used anywhere. For instance PXA168_SSP or PXA910_SSP. Then
>> PXA3xx_SSP is used in sound/soc/pxa/pxa-ssp.c and CE4100_SSP in
>> drivers/spi/spi-pxa2xx.c (where LPSS_SSP was used too before differentiating
>> it).
>
> IIRC the PXA168 and PXA910 are software compatible with the PXA3xx SPI
> controller.  Those SoCs never got wide distribution compared to the
> older PXA models I think.
>
>> What I'm wondering is this binding below correct in arch/arm/plat-pxa/ssp.c?
>> LPSS_SSP was meant to be for Intel Intel Low Power Subsystem SPI.
>
>> "{ .compatible = "mrvl,lpss-ssp",     .data = (void *) LPSS_SSP }"
>
>> Mika, Daniel: do you know is there any change there is a Marvell PXA
>> platform compatible with Intel LPSS or is above binding bogus?
>
> I bet it's just cut'n'paste because everything else about the driver and
> all the DT is for Marvell stuff.

The LPSS_SSP support was added by:
commit a0d2642e9296882cda3ad03ff3d9a6649cd70439
Author: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Date:   Tue Jan 22 12:26:32 2013 +0200

    spi/pxa2xx: add support for Intel Low Power Subsystem SPI

    Intel LPSS SPI is pretty much the same as the PXA27xx SPI except that it
    has few additional features over the original:

        o FIFO depth is 256 entries
        o RX FIFO has one watermark
        o TX FIFO has two watermarks, low and high
        o chip select can be controlled by writing to a register

    The new FIFO registers follow immediately the PXA27xx registers
but then there
    are some additional LPSS private registers at offset 1k or 2k from the base
    address. For these private registers we add new accessors that
take advantage
    of drv_data->lpss_base once it is resolved.

    We add a new type LPSS_SSP that can be used to distinguish the LPSS devices
    from others.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c

[Mika Westerberg]

On Tue, Sep 01, 2015 at 07:43:35PM +0100, Mark Brown wrote:
> > What I'm wondering is this binding below correct in arch/arm/plat-pxa/ssp.c?
> > LPSS_SSP was meant to be for Intel Intel Low Power Subsystem SPI.
> 
> > "{ .compatible = "mrvl,lpss-ssp",	.data = (void *) LPSS_SSP }"
> 
> > Mika, Daniel: do you know is there any change there is a Marvell PXA
> > platform compatible with Intel LPSS or is above binding bogus?
> 
> I bet it's just cut'n'paste because everything else about the driver and
> all the DT is for Marvell stuff.

I agree.

That entry definitely should not be there.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html