From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Mark Brown <broonie@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Axel Lin <axel.lin@ingics.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding
Date: Mon, 07 Sep 2015 10:24:41 +0300 [thread overview]
Message-ID: <55ED3BB9.8040202@linux.intel.com> (raw)
In-Reply-To: <87pp1yxais.fsf@belgarion.home>
On 09/04/2015 10:14 PM, Robert Jarzmik wrote:
> Jarkko Nikula <jarkko.nikula@bitmer.com> writes:
>
>> From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>>
>> Commit 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types") caused
>> build error here because it removed the type LPSS_SSP and I didn't notice
>> the type was used here too.
>>
>> I believe commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") added it
>> accidentally by copying all enum pxa_ssp_type types from
>> include/linux/pxa2xx_ssp.h even LPSS_SSP was for Intel LPSS SPI devices.
>>
>> Fix the build error by removing this incorrect binding.
>>
>> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>> Reported-by: Axel Lin <axel.lin@ingics.com>
>> Cc: stable@vger.kernel.org # 4.2
>> ---
>> Sorry if you got this twice today. I had email problems today and this patch
>> didn't go through to at least some of recipients. Resending from other my
>> another address.
>
> I'll take it through pxa tree, and I'll add this :
> Fixes: 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types")
>
> Up to my understanding this is the tag stable tree will use to know which kernel
> version this patch should be applied to.
>
Thanks for noticing. I added it and resent the patch as v2.
--
Jarkko
next prev parent reply other threads:[~2015-09-07 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1441208649-6192-1-git-send-email-jarkko.nikula@bitmer.com>
2015-09-04 19:14 ` [PATCH] ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding Robert Jarzmik
2015-09-07 7:24 ` Jarkko Nikula [this message]
2015-09-04 8:05 Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED3BB9.8040202@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).