From: Vignesh R <vigneshr@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>, <hramrach@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 1/5] spi: introduce mmap read support for spi flash devices
Date: Wed, 16 Sep 2015 15:38:09 +0530 [thread overview]
Message-ID: <55F93F89.7060708@ti.com> (raw)
In-Reply-To: <20150914183744.GF12027@sirena.org.uk>
On 09/15/2015 12:07 AM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 01:59:58PM +0530, Vignesh R wrote:
>> In addition to providing direct access to SPI bus, some spi controller
>> hardwares (like ti-qspi) provide special memory mapped port
>> to accesses SPI flash devices in order to increase read performance.
>> This means the controller can automatically send the SPI signals
>> required to read data from the SPI flash device.
>
> Sorry, also meant to say here: as I kind of indicated in response to the
> flash patch I'd expect to see the SPI core know something about this and
> export an API for this which is integrated with things like the existing
> message queue.
>
Adding an API to SPI core makes sense to me. This can take care of spi
bus locking and runtime pm.
But, I didn't get how to integrate with existing message queue. Memory
mapped read by-passes message queue of SPI core. Could you please
explain a bit more on integrating with message queue? Did you mean
locking the existing message queue when memory mapped read is being
requested?
Thanks,
Vignesh
next prev parent reply other threads:[~2015-09-16 10:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 8:29 [PATCH 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-09-04 8:29 ` [PATCH 1/5] spi: introduce mmap read support for spi flash devices Vignesh R
[not found] ` <1441355402-6837-2-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-09-04 11:25 ` Jagan Teki
[not found] ` <CAD6G_RT8Q+Uyp1ZjzHf54Tno1wHm0SmLKEwRAe2gkdp772FD9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 18:35 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
[not found] ` <20150914183553.GE12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-16 12:46 ` Jagan Teki
[not found] ` <CAD6G_RQOazkS7KHrG75wgMXx1cH_pKjx43Mve6fz1qOJGPpq9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-16 15:24 ` Mark Brown
2015-09-16 15:30 ` Michal Suchanek
2015-09-14 18:37 ` Mark Brown
2015-09-16 10:08 ` Vignesh R [this message]
[not found] ` <55F93F89.7060708-l0cyMroinI0@public.gmane.org>
2015-09-16 10:56 ` Mark Brown
2015-09-18 12:10 ` Vignesh R
2015-09-04 8:29 ` [PATCH 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-09-14 18:26 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
2015-09-04 8:30 ` [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
[not found] ` <1441355402-6837-4-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-09-14 18:27 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
[not found] ` <1441355402-6837-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-09-04 8:30 ` [PATCH 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-09-04 8:30 ` [PATCH 5/5] ARM: dts: AM4372: " Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F93F89.7060708@ti.com \
--to=vigneshr@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).