From: Andreas Ziegler <andreas.ziegler@fau.de>
To: Jonas Gorski <jogo@openwrt.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Valentin Rothberg <rothberg@cs.fau.de>,
Paul Bolle <pebolle@tiscali.nl>
Subject: Re: spi/bcm63xx: fix standard accessors and compile guard
Date: Tue, 13 Oct 2015 21:30:41 +0200 [thread overview]
Message-ID: <561D5BE1.2040109@fau.de> (raw)
Hi Jonas,
your patch "spi/bcm63xx: fix standard accessors and compile guard"
showed up as commit 682b5280bf00 in linux-next today (that is,
next-20151013). I noticed it because we (a research group from
Erlangen[0]) are running daily checks on linux-next.
Your commit fixes two #ifdef statements in drivers/spi/spi-bcm63xx.c
which involve CONFIG_CPU_BIG_ENDIAN.
>From the Makefile at drivers/spi/Makefile (line 20), we can see that the
file can only be built when CONFIG_SPI_BCM63XX is set. In the
corresponding Kconfig file (drivers/spi/Kconfig, line 137),
CONFIG_SPI_BCM63XX is defined to depend on CONFIG_BCM63XX. The latter is
defined in arch/mips/Kconfig (line 199), and selects
CONFIG_SYS_SUPPORTS_BIG_ENDIAN (but not CONFIG_SYS_SUPPORTS_LITTLE_ENDIAN).
Finally, CONFIG_CPU_BIG_ENDIAN (at arch/mips/Kconfig, line 1136) depends
on CONFIG_SYS_SUPPORTS_BIG_ENDIAN, which means that if the source file
is to be compiled, CONFIG_CPU_BIG_ENDIAN is the only possible selection
in the endianness choice. Hence, the #ifdefs are unnecessary and could
possibly be removed.
Is this correct, or am I missing something?
Best regards,
Andreas
[0] https://cados.cs.fau.de
reply other threads:[~2015-10-13 19:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D5BE1.2040109@fau.de \
--to=andreas.ziegler@fau.de \
--cc=broonie@kernel.org \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rothberg@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).