From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
To: "Franklin S Cooper Jr." <fcooper-l0cyMroinI0@public.gmane.org>,
Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Ivan T. Ivanov"
<iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>,
<m-karicheri2-l0cyMroinI0@public.gmane.org>,
"Ivan T. Ivanov"
<iivanov.xz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
<hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ivan Khoronzhuk
<ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect
Date: Tue, 27 Oct 2015 15:34:04 +0200 [thread overview]
Message-ID: <562F7D4C.4080005@ti.com> (raw)
In-Reply-To: <562F7801.3090508-l0cyMroinI0@public.gmane.org>
On 10/27/2015 03:11 PM, Grygorii Strashko wrote:
> On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote:
>>
>>
>> On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
>>> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr.
>>> <fcooper-l0cyMroinI0@public.gmane.org> wrote:
>>>>
>>>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr
>>>>> <fcooper-l0cyMroinI0@public.gmane.org> wrote:
>>>>>> SPI controllers may need to be properly setup before chip selects
>>>>>> can be used. Therefore, wait until the spi controller has a chance
>>>>>> to perform their setup procedure before trying to use the chip
>>>>>> select.
>>>>>>
>>>>>> This also insures that the chip selects pins are in a good
>>>>>> state before asseting them which otherwise may cause confusion.
>>>>>>
>>>>>> Signed-off-by: Franklin S Cooper Jr <fcooper-l0cyMroinI0@public.gmane.org>
>>>>> Does it mean I have to test it again?
>>>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your
>>>> tested by included.
>>> Whatever Mark prefers.
>> Hi Mark,
>> I don't see that you pulled this patch into your topic/core branch
>> just yet. Would you prefer
>> for me to shoot a v3 with Andy's tested by or will you just add it
>> when your ready to
>> pull it in?
>>
>> Without this patch several of our boards don't boot in linux-next so
>> if there is anything you
>> need for me to do please let me know.
>>>
>>>
>>
>
> Boot tested on K2HK:
>
> Tested-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
> Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
Sry, Fix Ivan's e-mail
Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-27 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 15:29 [PATCH v2] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr
2015-10-16 15:45 ` Andy Shevchenko
2015-10-16 15:47 ` Franklin S Cooper Jr.
2015-10-16 15:55 ` Andy Shevchenko
[not found] ` <CAHp75VchYayRsvsjPoM9YphcjMajfvYuDrLcLrTiADVn8LU=8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-27 12:22 ` Franklin S Cooper Jr.
[not found] ` <562F6C9B.6010607-l0cyMroinI0@public.gmane.org>
2015-10-27 13:11 ` Grygorii Strashko
[not found] ` <562F7801.3090508-l0cyMroinI0@public.gmane.org>
2015-10-27 13:34 ` Grygorii Strashko [this message]
2015-10-28 0:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F7D4C.4080005@ti.com \
--to=grygorii.strashko-l0cymroini0@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=fcooper-l0cyMroinI0@public.gmane.org \
--cc=hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org \
--cc=iivanov.xz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).