Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: spi: tests driver to test basic alignment/length issues via loopback
Date: Thu, 26 Nov 2015 11:02:17 +0100	[thread overview]
Message-ID: <5656D8A9.20102@martin.sperl.org> (raw)
In-Reply-To: <CAMuHMdX6AVqhDUyvxgPGOdVYi4LPAm7CCGD-M7sUQCbXZJ+49w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 26.11.2015 10:54, Geert Uytterhoeven wrote:
> Hi Martin,
>
> On Wed, Nov 25, 2015 at 7:56 PM, Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> wrote:
>> For complete testing the only thing it requires is  MOSI connected to MISO.
>> and then it can detect lots of situations:
>
> BTW, with several SPI drivers, you can set SPI_LOOP instead.
> This can be useful on boards where the SPI pins are not available on
> expansion headers, or where the pins are used for other functions.
I thought of adding spi_msg to the spi_test structure as well,
but as spi_message_init clears all the data in spi_message,
I did not want to take that step...

Also I fear that with SPI_LOOP some drivers may take some short-cuts
copying the data directly without going via the HW, which would result
in testing a different code-path than in reality and thus resulting
in bogus positive results.

Anyway: we can always extend it to include these kinds of things later.
(maybe even add auto-detection if there is a flag for it...)

Martin






--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-26 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 18:56 spi: tests driver to test basic alignment/length issues via loopback Martin Sperl
     [not found] ` <753FCC7B-67D9-495B-A6C1-D49793502C90-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-11-26  9:32   ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdVpds0hOD=4uh1ZA+pfk9wHQJiuJodgXJDG0VcmYRXkeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-26  9:48       ` Martin Sperl
2015-11-26  9:54   ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdX6AVqhDUyvxgPGOdVYi4LPAm7CCGD-M7sUQCbXZJ+49w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-26 10:02       ` Martin Sperl [this message]
2015-11-26 12:18   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5656D8A9.20102@martin.sperl.org \
    --to=kernel-tqfnsx0mhmxhksadf0wuew@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox