From: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/4] spi: mediatek: merge all identical compat to mtk_common_compat
Date: Thu, 31 Dec 2015 09:32:07 +0100 [thread overview]
Message-ID: <5684E807.30300@gmail.com> (raw)
In-Reply-To: <1451530743-8995-2-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On 31/12/15 03:59, Leilk Liu wrote:
> This patch merge all identical compat into on mtk_common_compat
> and used for all compatible soc.
>
> Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> drivers/spi/spi-mt65xx.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> index 563954a..3573c09 100644
> --- a/drivers/spi/spi-mt65xx.c
> +++ b/drivers/spi/spi-mt65xx.c
> @@ -95,8 +95,7 @@ struct mtk_spi {
> const struct mtk_spi_compatible *dev_comp;
> };
>
> -static const struct mtk_spi_compatible mt6589_compat;
> -static const struct mtk_spi_compatible mt8135_compat;
> +static const struct mtk_spi_compatible mtk_common_compat;
> static const struct mtk_spi_compatible mt8173_compat = {
> .need_pad_sel = true,
> .must_tx = true,
> @@ -112,9 +111,15 @@ static const struct mtk_chip_config mtk_default_chip_info = {
> };
>
> static const struct of_device_id mtk_spi_of_match[] = {
> - { .compatible = "mediatek,mt6589-spi", .data = (void *)&mt6589_compat },
> - { .compatible = "mediatek,mt8135-spi", .data = (void *)&mt8135_compat },
> - { .compatible = "mediatek,mt8173-spi", .data = (void *)&mt8173_compat },
> + { .compatible = "mediatek,mt6589-spi",
> + .data = (void *)&mtk_common_compat,
> + },
> + { .compatible = "mediatek,mt8135-spi",
> + .data = (void *)&mtk_common_compat,
> + },
> + { .compatible = "mediatek,mt8173-spi",
> + .data = (void *)&mt8173_compat,
> + },
> {}
> };
> MODULE_DEVICE_TABLE(of, mtk_spi_of_match);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-31 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 2:58 [PATCH 0/4] SPI: support mt2701 IC Leilk Liu
[not found] ` <1451530743-8995-1-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-31 2:59 ` [PATCH 1/4] spi: mediatek: merge all identical compat to mtk_common_compat Leilk Liu
[not found] ` <1451530743-8995-2-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-31 8:32 ` Matthias Brugger [this message]
2015-12-31 22:18 ` Applied "spi: mediatek: merge all identical compat to mtk_common_compat" to the spi tree Mark Brown
2015-12-31 2:59 ` [PATCH 2/4] spi: mediatek: Add spi support for mt2701 IC Leilk Liu
[not found] ` <1451530743-8995-3-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-31 22:18 ` Applied "spi: mediatek: Add spi support for mt2701 IC" to the spi tree Mark Brown
2015-12-31 2:59 ` [PATCH 3/4] dts: mt2701: add spi dts for mt2701 Leilk Liu
2015-12-31 2:59 ` [PATCH 4/4] Document: spi: Add bindings for mediatek MT2701 soc platform Leilk Liu
[not found] ` <1451530743-8995-5-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-31 22:08 ` Mark Brown
2015-12-31 22:15 ` Rob Herring
2015-12-31 22:18 ` Applied "spi: mtk: Add bindings for mediatek MT2701 soc platform" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5684E807.30300@gmail.com \
--to=matthias.bgg-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).