From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring the spi Date: Thu, 07 Jul 2016 11:41:49 +0200 Message-ID: <577E23DD.1040906@samsung.com> References: <1467876237-12183-1-git-send-email-andi.shyti@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-samsung-soc@vger.kernel.org, Andi Shyti , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Kukjin Kim , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org To: Andi Shyti , Mark Brown Return-path: In-reply-to: <1467876237-12183-1-git-send-email-andi.shyti@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 07/07/2016 09:23 AM, Andi Shyti wrote: > When the clock is coming from the cmu it is not required to be > disabled and then re-enabled in order to change the rate. > > Besides, some exynos chipsets (e.g. exynos5433) do not deliver > any to the SFR if one from the pclk ("spi" in this case) or sclk > ("busclk") is disabled. > > Remove the clock disabling/enabling to avoid falling into this > situation. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Andi Shyti > --- > > Hi, > > This patch has been tested by me and Sylwester on Trats2 > (exynos4412) and tm2(e) (exynos5433) boards, for big data > (which use dma transfer) and small data. > > It also fixes in exynos5433 a synchronus abort caused by the fact > that the pclk (spi) doesn't get delivered if the sclk is disabled > (busclk) > > Thanks, > Andi > > drivers/spi/spi-s3c64xx.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof