From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: William Zhang <william.zhang@broadcom.com>,
Linux SPI List <linux-spi@vger.kernel.org>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: tomer.yacoby@broadcom.com, kursad.oney@broadcom.com,
dregan@mail.com, f.fainelli@gmail.com, anand.gore@broadcom.com,
jonas.gorski@gmail.com, dan.beygelman@broadcom.com,
joel.peshkin@broadcom.com,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/14] ARM: dts: broadcom: bcmbca: Add spi controller node
Date: Wed, 25 Jan 2023 08:36:21 +0100 [thread overview]
Message-ID: <5b4bf72e-37e5-0840-cacb-df3873c3a5c9@linaro.org> (raw)
In-Reply-To: <20230124221218.341511-4-william.zhang@broadcom.com>
On 24/01/2023 23:12, William Zhang wrote:
> Add support for HSSPI controller in ARMv7 chip dts files.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>
> ---
>
> Changes in v2:
> - Update compatible string with SoC model number, controller version
> info and bcmbca fall back name
> - Add interrupt property
>
> arch/arm/boot/dts/bcm47622.dtsi | 19 +++++++++++++++++++
> arch/arm/boot/dts/bcm63138.dtsi | 19 +++++++++++++++++++
> arch/arm/boot/dts/bcm63148.dtsi | 19 +++++++++++++++++++
> arch/arm/boot/dts/bcm63178.dtsi | 20 ++++++++++++++++++++
> arch/arm/boot/dts/bcm6756.dtsi | 20 ++++++++++++++++++++
> arch/arm/boot/dts/bcm6846.dtsi | 19 +++++++++++++++++++
> arch/arm/boot/dts/bcm6855.dtsi | 20 ++++++++++++++++++++
> arch/arm/boot/dts/bcm6878.dtsi | 20 ++++++++++++++++++++
> arch/arm/boot/dts/bcm947622.dts | 4 ++++
> arch/arm/boot/dts/bcm963138.dts | 4 ++++
> arch/arm/boot/dts/bcm963138dvt.dts | 4 ++++
> arch/arm/boot/dts/bcm963148.dts | 4 ++++
> arch/arm/boot/dts/bcm963178.dts | 4 ++++
> arch/arm/boot/dts/bcm96756.dts | 4 ++++
> arch/arm/boot/dts/bcm96846.dts | 4 ++++
> arch/arm/boot/dts/bcm96855.dts | 4 ++++
> arch/arm/boot/dts/bcm96878.dts | 4 ++++
> 17 files changed, 192 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm47622.dtsi b/arch/arm/boot/dts/bcm47622.dtsi
> index f4b2db9bc4ab..6de4a2287c90 100644
> --- a/arch/arm/boot/dts/bcm47622.dtsi
> +++ b/arch/arm/boot/dts/bcm47622.dtsi
> @@ -88,6 +88,12 @@ uart_clk: uart-clk {
> clock-div = <4>;
> clock-mult = <1>;
> };
> +
> + hsspi_pll: hsspi-pll {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <200000000>;
> + };
> };
>
> psci {
> @@ -119,6 +125,19 @@ bus@ff800000 {
> #size-cells = <1>;
> ranges = <0 0xff800000 0x800000>;
>
> + hsspi: spi@1000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "brcm,bcm47622-hsspi", "brcm,bcmbca-hsspi-v1.0",
> + "brcm,bcmbca-hsspi";
Several of your lines are not properly indented/aligned.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-25 7:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 22:12 [PATCH v2 00/14] spi: bcm63xx-hsspi: driver and doc updates William Zhang
2023-01-24 22:12 ` [PATCH v2 01/14] dt-bindings: spi: Convert bcm63xx-hsspi bindings to json-schema William Zhang
2023-01-25 7:31 ` Krzysztof Kozlowski
2023-01-24 22:12 ` [PATCH v2 02/14] dt-bindings: spi: Add bcmbca-hsspi controller support William Zhang
2023-01-25 7:35 ` Krzysztof Kozlowski
2023-01-25 19:23 ` William Zhang
2023-01-25 20:51 ` Rob Herring
2023-01-25 21:40 ` William Zhang
2023-01-26 13:56 ` Rob Herring
2023-01-26 20:04 ` William Zhang
2023-01-24 22:12 ` [PATCH v2 03/14] ARM: dts: broadcom: bcmbca: Add spi controller node William Zhang
2023-01-25 7:36 ` Krzysztof Kozlowski [this message]
2023-01-24 22:12 ` [PATCH v2 04/14] arm64: " William Zhang
2023-01-24 22:12 ` [PATCH v2 05/14] spi: bcm63xx-hsspi: Add new compatible string support William Zhang
2023-01-24 22:12 ` [PATCH v2 06/14] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC William Zhang
2023-01-24 22:48 ` Florian Fainelli
2023-01-24 22:12 ` [PATCH v2 07/14] spi: bcm63xx-hsspi: Add polling mode support William Zhang
2023-01-24 22:12 ` [PATCH v2 08/14] spi: bcm63xx-hsspi: Handle cs_change correctly William Zhang
2023-01-26 15:12 ` Jonas Gorski
2023-01-26 16:22 ` Kursad Oney
2023-01-26 17:33 ` Jonas Gorski
2023-01-27 3:10 ` William Zhang
2023-01-24 22:12 ` [PATCH v2 09/14] spi: bcm63xx-hsspi: Fix multi-bit mode setting William Zhang
2023-01-24 22:12 ` [PATCH v2 10/14] spi: bcm63xx-hsspi: Add prepend mode support William Zhang
2023-01-26 15:15 ` Jonas Gorski
2023-01-26 15:33 ` Mark Brown
2023-01-27 2:59 ` William Zhang
2023-01-24 22:12 ` [PATCH v2 11/14] spi: spi-mem: Allow controller supporting mem_ops without exec_op William Zhang
2023-01-24 22:12 ` [PATCH v2 12/14] spi: bcm63xx-hsspi: Disable spi mem dual io William Zhang
2023-01-26 15:15 ` Jonas Gorski
2023-01-27 2:04 ` William Zhang
2023-01-24 22:12 ` [PATCH v2 13/14] spi: bcmbca-hsspi: Add driver for newer HSSPI controller William Zhang
2023-01-26 15:16 ` Jonas Gorski
2023-01-27 2:17 ` William Zhang
2023-01-24 22:12 ` [PATCH v2 14/14] MAINTAINERS: Add entry for Broadcom Broadband SoC HS SPI drivers William Zhang
2023-01-24 22:50 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b4bf72e-37e5-0840-cacb-df3873c3a5c9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dregan@mail.com \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=tomer.yacoby@broadcom.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).