linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: spidev: Adjust five checks for null pointers
Date: Thu, 18 May 2017 16:34:45 +0200	[thread overview]
Message-ID: <5d9f71d4-2f0d-7083-fd28-fb505841b502@users.sourceforge.net> (raw)
In-Reply-To: <20170518112846.tcirhguyps3kk3ra@sirena.org.uk>

>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
> 
> Please fix however you're sending things out to avoid this noise.

The Git software generated such extra information because my commit message
contained a few special characters.


>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
> 
> This changelog does not describe any purpose in making this change,
> we could equally well say the exact opposite.  Why should we do this?

How do you think about to reduce the usage of the preprocessor symbol “NULL”?

Can it help if the source code is a little bit shorter after the
proposed adjustment?

Regards,
Markus

  reply	other threads:[~2017-05-18 14:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 15:43 [PATCH 0/2] spidev: Adjustments for six function implementations SF Markus Elfring
     [not found] ` <c5452d8c-d123-d5e9-b2cc-a386d1325aec-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-05-17 15:45   ` [PATCH 1/2] spidev: Delete error messages for failed memory allocations in spidev_open() SF Markus Elfring
2017-05-17 15:47   ` [PATCH 2/2] spidev: Adjust five checks for null pointers SF Markus Elfring
     [not found]     ` <df3e58c6-f70d-a5d3-102e-4fab2f7df126-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-05-18 11:28       ` Mark Brown
2017-05-18 14:34         ` SF Markus Elfring [this message]
     [not found]           ` <5d9f71d4-2f0d-7083-fd28-fb505841b502-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-05-22 12:33             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d9f71d4-2f0d-7083-fd28-fb505841b502@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).