From: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Subject: [PATCH 3/5] spi: sunxi: expose maximum transfer size limit
Date: 26 May 2016 19:25:24 -0000 [thread overview]
Message-ID: <5fffb7eca6f4b70853d92be2403595d6d06bede7.1464130597.git.hramrach@gmail.com> (raw)
In-Reply-To: <cover.1464130597.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
The sun4i spi hardware can trasfer at most 63 bytes of data without DMA
support so report the limitation. Same on sun6i.
Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi-sun4i.c | 6 ++++++
drivers/spi/spi-sun6i.c | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c
index 04f1b77..bf52b09 100644
--- a/drivers/spi/spi-sun4i.c
+++ b/drivers/spi/spi-sun4i.c
@@ -167,6 +167,11 @@ static void sun4i_spi_set_cs(struct spi_device *spi, bool enable)
sun4i_spi_write(sspi, SUN4I_CTL_REG, reg);
}
+static size_t sun4i_spi_max_transfer_size(struct spi_device *spi)
+{
+ return SUN4I_FIFO_DEPTH - 1;
+}
+
static int sun4i_spi_transfer_one(struct spi_master *master,
struct spi_device *spi,
struct spi_transfer *tfr)
@@ -407,6 +412,7 @@ static int sun4i_spi_probe(struct platform_device *pdev)
master->bits_per_word_mask = SPI_BPW_MASK(8);
master->dev.of_node = pdev->dev.of_node;
master->auto_runtime_pm = true;
+ master->max_transfer_size = sun4i_spi_max_transfer_size;
sspi->hclk = devm_clk_get(&pdev->dev, "ahb");
if (IS_ERR(sspi->hclk)) {
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index 8954a62..f491a41 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -154,6 +154,11 @@ static void sun6i_spi_set_cs(struct spi_device *spi, bool enable)
}
+static size_t sun6i_spi_max_transfer_size(struct spi_device *spi)
+{
+ return SUN6I_FIFO_DEPTH - 1;
+}
+
static int sun6i_spi_transfer_one(struct spi_master *master,
struct spi_device *spi,
struct spi_transfer *tfr)
@@ -418,6 +423,7 @@ static int sun6i_spi_probe(struct platform_device *pdev)
master->bits_per_word_mask = SPI_BPW_MASK(8);
master->dev.of_node = pdev->dev.of_node;
master->auto_runtime_pm = true;
+ master->max_transfer_size = sun6i_spi_max_transfer_size;
sspi->hclk = devm_clk_get(&pdev->dev, "ahb");
if (IS_ERR(sspi->hclk)) {
--
2.8.1
next prev parent reply other threads:[~2016-05-26 19:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 22:56 [PATCH 0/5] sunxi spi fixes Michal Suchanek
[not found] ` <cover.1464130597.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-26 19:25 ` [PATCH 1/5] spi: sunxi: fix transfer timeout Michal Suchanek
[not found] ` <cb90b922caa6ac07c1425d726ea19709ee5284f4.1464130597.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-27 2:05 ` [linux-sunxi] " Julian Calaby
[not found] ` <CAGRGNgWDrVHG26umTSHHAxFC3KXjwmpDejBAfKqvuik0_2-Jcw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-27 5:05 ` Michal Suchanek
[not found] ` <CAOMqctS0AD6rHGt3wjxxyidee=_5xqby95t5TGuozAA12DdPjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-27 5:10 ` Julian Calaby
[not found] ` <CAGRGNgW=UnmwwiREV+nVcws6sk18-4fKz3qf-WKf4LY9-VqBKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-30 11:23 ` [linux-sunxi] " Mark Brown
[not found] ` <20160530112350.GI29837-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-31 11:52 ` Michal Suchanek
2016-06-01 18:20 ` [linux-sunxi] " Maxime Ripard
2016-05-30 9:44 ` Maxime Ripard
2016-05-26 19:25 ` Michal Suchanek [this message]
[not found] ` <5fffb7eca6f4b70853d92be2403595d6d06bede7.1464130597.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-30 8:37 ` [PATCH 3/5] spi: sunxi: expose maximum transfer size limit Maxime Ripard
2016-05-30 8:57 ` Michal Suchanek
[not found] ` <CAOMqctQdbipvvTnF253S4jGDos1crYXk9nuzDcRvy4geeS=GrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-01 18:14 ` Maxime Ripard
2016-05-26 19:25 ` [PATCH 2/5] spi: sun4i: fix FIFO limit Michal Suchanek
[not found] ` <e315008b5e9dc3f1490507508fd2f6e94767dfbb.1464130597.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-30 8:37 ` Maxime Ripard
2016-05-26 19:25 ` [PATCH 5/5] RFC spi: sun4i: add DMA support Michal Suchanek
[not found] ` <ba0d6eb37cc4b0d2c46acbf9fcd7d644b3545ce8.1464130597.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-30 11:26 ` Mark Brown
[not found] ` <20160530112610.GJ29837-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-30 12:11 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVThvtqgFnyqoqypwwf1d81uu9NBo6-heTZBcvBxRevNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-30 15:03 ` Mark Brown
[not found] ` <20160530150343.GL29837-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-30 15:28 ` Michal Suchanek
[not found] ` <CAOMqctQb-YYprA7H5qCcYo2hxXiUhjW2z3JbZ3-FhbfcjFzBpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-30 15:50 ` Mark Brown
[not found] ` <20160530155016.GO29837-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-31 10:44 ` Michal Suchanek
[not found] ` <CAOMqctQijjO2amwSmSMGp96KBRGrLb0fvXRwnybOEqvV3-HZ0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-31 13:27 ` Mark Brown
[not found] ` <20160531132706.GC29837-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-31 14:19 ` Michal Suchanek
[not found] ` <CAOMqctSWnbUaOveMUhz+yOJqTOK4EhDd5jUqKoHCohfndNAjWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-02 8:18 ` Maxime Ripard
2016-06-01 18:00 ` Maxime Ripard
2016-06-02 4:42 ` Priit Laes
[not found] ` <1464842546.23881.3.camel-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2016-06-02 9:18 ` Mark Brown
2016-06-02 12:14 ` [linux-sunxi] " Michal Suchanek
[not found] ` <CAOMqctRMi8Zuwqvakka8LkgvecWVAfzUcER9+ui9WBYS78fWtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-02 14:26 ` Mark Brown
[not found] ` <20160602142649.GJ2282-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-05 11:27 ` Michal Suchanek
[not found] ` <CAOMqctQwFif=yFF1snfZJc7+sGS7wcC-6oNTCfjW_MSUWHw+xQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-06 11:36 ` Mark Brown
2016-05-26 19:25 ` [PATCH 4/5] spi: sunxi: set maximum and minimum speed of SPI master Michal Suchanek
2016-05-30 9:17 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fffb7eca6f4b70853d92be2403595d6d06bede7.1464130597.git.hramrach@gmail.com \
--to=hramrach-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).