From: Tomasz Figa <t.figa@samsung.com>
To: Mark Brown <broonie@kernel.org>,
Rajeshwari Birje <rajeshwari.birje@gmail.com>
Cc: Rajeshwari S Shinde <rajeshwari.s@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-spi@vger.kernel.org, Simon Glass <sjg@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Doug Anderson <dianders@google.com>
Subject: Re: [PATCH V4] spi: s3c64xx: Enable Word transfer
Date: Wed, 30 Oct 2013 18:06:30 +0100 [thread overview]
Message-ID: <6043727.WVyVGYjJys@amdc1227> (raw)
In-Reply-To: <20131030170029.GK2493@sirena.org.uk>
On Wednesday 30 of October 2013 10:00:29 Mark Brown wrote:
> On Wed, Oct 30, 2013 at 11:52:54AM +0530, Rajeshwari Birje wrote:
>
> > The following patch already sets bits_per_word_mask for
> > drivers/spi/spi-s3c64xx.c in s3c64xx_spi_probe, hence I had a doubt do
> > I need to set the same again.
>
> OK, so how did this work before then? You're just adding new code but
> the driver was previously claiming to support different bits per word
> (and now I look at the code there is some handling for that in code).
> Is this a bug fix?
That's a good question. Rajeshwari, what SPI device did you test this
patch with? Does it have a driver in mainline kernel?
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-30 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 5:32 [PATCH V4] spi: s3c64xx: Enable Word transfer Rajeshwari S Shinde
[not found] ` <1382074356-28430-1-git-send-email-rajeshwari.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-19 16:25 ` Mark Brown
[not found] ` <CAPnjgZ1A335KstnpTRwpxEbBArtqh1sYSPQJBw6LX5zUeptpfA@mail.gmail.com>
2013-10-19 20:04 ` Mark Brown
2013-10-29 10:59 ` Rajeshwari Birje
[not found] ` <CAPs=JDeOqkJT32quBH1tF9FtFUOt=CHP7m6ZqzhfASM2uPj-dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-29 11:29 ` Rajeshwari Birje
[not found] ` <CAPs=JDdzvnM5BzgRLhLsJrdwcVSwxd6x8_kFz0EvB=OjFfVszw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-29 16:39 ` Mark Brown
[not found] ` <20131029163926.GA6776-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-10-30 6:22 ` Rajeshwari Birje
[not found] ` <CAPs=JDeDbevjOtMH0y+9aVSbNSV4zmEQxWygtB-f69XzooSinQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-30 17:00 ` Mark Brown
2013-10-30 17:06 ` Tomasz Figa [this message]
2013-10-31 10:47 ` Rajeshwari Birje
2013-10-31 12:37 ` Tomasz Figa
2013-11-06 4:53 ` Rajeshwari Birje
2013-11-06 8:21 ` Mark Brown
[not found] ` <20131106082141.GA11602-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-07 9:22 ` Rajeshwari Birje
[not found] ` <CAPs=JDctq1yRbuwnFH40dnQJJHF0C_D1p3iVokSPusPXA27Qeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-07 9:39 ` Tomasz Figa
2013-11-07 9:59 ` Lukasz Czerwinski
2013-11-08 11:05 ` Mark Brown
2013-11-10 17:26 ` Tomasz Figa
2013-11-13 8:28 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6043727.WVyVGYjJys@amdc1227 \
--to=t.figa@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=dianders@google.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rajeshwari.birje@gmail.com \
--cc=rajeshwari.s@samsung.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).