From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23352C433F5 for ; Wed, 9 Feb 2022 16:44:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236977AbiBIQo0 (ORCPT ); Wed, 9 Feb 2022 11:44:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236897AbiBIQoY (ORCPT ); Wed, 9 Feb 2022 11:44:24 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7A4F3C0612BE for ; Wed, 9 Feb 2022 08:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644425066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KaPxvUPz73vOAGz6EpqAVnHUMksefzUrg4OPSPo/82E=; b=EO5+ml0wGH+2oUb7ToKNMCPM5zT7DGq22SZFRsJtoED5ylMJsCMUl+ycCItPVr/x11RE8W IOkZoAV7R83kYVwHrm1VnqUoQOEfcmdp6c8120FJo6PrjokkQDdQzzzFbJNqNqQHkpfaHN 8MKMzdd1Q4vXqeILMiYQvYX0EF68mz0= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-399-DdSWMtWzNGWOTj3oGy3Kew-1; Wed, 09 Feb 2022 11:44:25 -0500 X-MC-Unique: DdSWMtWzNGWOTj3oGy3Kew-1 Received: by mail-qt1-f197.google.com with SMTP id br10-20020a05622a1e0a00b002d37e07e79aso2178474qtb.4 for ; Wed, 09 Feb 2022 08:44:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=KaPxvUPz73vOAGz6EpqAVnHUMksefzUrg4OPSPo/82E=; b=et5qzV6fSQ/BB5Q6ftPCyy9udhRdbtHqpIaZWdUHu23aA1Yxmu29qX9+RX62qHNDEJ ABzJuMOiFGs15ACnvQBATfFzU0mkck/3UhA5EWkmITdPT3YPazwtixvtYX+s2/eo0Ksi bB167kFL0jmKlOIgseUKrs5cdT5GdiRRMESJf6ffRHzRf3vMeLlAYH9cEws3GB0wuW6J lG062wRmbtQfDbbdlDV0xQZ+NPtjaJ93L+66ttTV1Nd1aBHXTKx02Xfzu6XyjN/VqpC6 TeaBo8nkaYKSvDl1T/j/O3AlaLhf0uK3JltRobso7CWNRoM9AykxTxtVkoTbovSskXRj YWTg== X-Gm-Message-State: AOAM532DuxSbPaXz307UkLT7i0iAVuq1Adpo23J4bHaPXzACewCNpwpM c6F8gYunblfVp/pSCWkThHxRi/4tDpkdJ/4kya79RHqAObcdSqg0Rf2vFc3+wKNxf7QibkXKm7T SO/Hs6Otz1kMXJJJLstBJ X-Received: by 2002:ad4:5f8a:: with SMTP id jp10mr2065525qvb.14.1644425065009; Wed, 09 Feb 2022 08:44:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJybkvzBKSgzu3wGFvXoOyk0MMma2dAefl2ZmvFzuoL1BtcD2RSBS5I5yrk8+S9FDrmA/r6VMQ== X-Received: by 2002:ad4:5f8a:: with SMTP id jp10mr2065512qvb.14.1644425064775; Wed, 09 Feb 2022 08:44:24 -0800 (PST) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id q15sm8760820qti.41.2022.02.09.08.44.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 08:44:24 -0800 (PST) Subject: Re: [PATCH] spi: initialize ret variable To: Mark Brown Cc: lhjeff911@gmail.com, nathan@kernel.org, ndesaulniers@google.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20220209163029.2299009-1-trix@redhat.com> From: Tom Rix Message-ID: <61a545d5-224d-86fb-2fe3-406c3ffd78fb@redhat.com> Date: Wed, 9 Feb 2022 08:44:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 2/9/22 8:33 AM, Mark Brown wrote: > On Wed, Feb 09, 2022 at 08:30:29AM -0800, trix@redhat.com wrote: >> From: Tom Rix >> >> Clang build fails with >> spi-sunplus-sp7021.c:405:2: error: variable 'ret' is used >> uninitialized whenever switch default is taken >> default: >> ^~~~~~~ >> >> Restore initializing ret. > Are you sure this is a good fix and that the compiler hasn't instead > identifed that we should be returning an error in the default case? If setting mode to idle is not really a valid state, then default should return an error. The old behavior returned 0 and I am treating this as a regression. Tom