From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: rafael@kernel.org
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-spi@vger.kernel.org, broonie@kernel.org
Subject: Re: [PATCH 07/13] drivers: Add generic match helper by ACPI_COMPANION device
Date: Wed, 12 Jun 2019 10:43:38 +0100 [thread overview]
Message-ID: <621f33db-d7d8-380e-fe50-effb27523068@arm.com> (raw)
In-Reply-To: <CAJZ5v0i0WP88+vTEheSTfAoSi5nEdjaLs4KOGxXK3_AoPhPrhg@mail.gmail.com>
Hi Rafael,
On 06/06/2019 10:57, Rafael J. Wysocki wrote:
> On Thu, Jun 6, 2019 at 11:28 AM Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>>
>>
>>
>> On 06/06/2019 10:17, Rafael J. Wysocki wrote:
>>> On Wed, Jun 5, 2019 at 5:14 PM Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>>>>
>>>> Add a generic helper to match a device by the acpi device.
>>>
>>> "by its ACPI companion device object", please.
>>
>> Sure.
>>
>>>
>>> Also, it would be good to combine this patch with the patch(es) that
>>> cause device_match_acpi_dev() to be actually used.
>>>
>>> Helpers without any users are arguably not useful.
>>
>> Sure, the helpers will be part of the part2 of the whole series,
>> which will actually have the individual subsystems consuming the
>> new helpers. For your reference, it is available here :
>>
>> http://linux-arm.org/git?p=linux-skp.git;a=shortlog;h=refs/heads/driver-cleanup/v2
>>
>> e.g:
>> http://linux-arm.org/git?p=linux-skp.git;a=commit;h=59534e843e2f214f1f29659993f6e423bef16b28
>>
>> I could simply pull those patches into this part, if you prefer that.
>
> Not really.
>
> I'd rather do it the other way around: push the introduction of the
> helpers to part 2.
Sure, I will do that.
>
>> However, that would be true for the other patches in the part2.
>> I am open to suggestions, on how to split the series.
>
> You can introduce each helper along with its users in one patch.
>
> This way the total number of patches will be reduced and they will be
> easier to review IMO.
>
Wouldn't it make the merging complicated ? I am still not clear how we plan
to merge the part 2 ?
Cheers
Suzuki
next prev parent reply other threads:[~2019-06-12 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 15:13 [PATCH 00/13] drivers: Introduce generic device lookup helpers Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 04/13] drivers: Add generic helper to match by of_node Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 07/13] drivers: Add generic match helper by ACPI_COMPANION device Suzuki K Poulose
2019-06-06 9:17 ` Rafael J. Wysocki
2019-06-06 9:28 ` Suzuki K Poulose
2019-06-06 9:57 ` Rafael J. Wysocki
2019-06-12 9:43 ` Suzuki K Poulose [this message]
2019-06-12 22:07 ` Rafael J. Wysocki
2019-06-05 15:13 ` [PATCH 11/13] drivers: Introduce variants for bus_find_device() Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621f33db-d7d8-380e-fe50-effb27523068@arm.com \
--to=suzuki.poulose@arm.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).