From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-spi@vger.kernel.org, "Mark Brown" <broonie@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
openbmc@lists.ozlabs.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)
Date: Tue, 29 Nov 2022 09:06:07 +0100 [thread overview]
Message-ID: <657e7d50-7352-1a4f-6977-cf1d9c6e6c8e@linaro.org> (raw)
In-Reply-To: <20221128214928.3531463-3-j.neuschaefer@gmx.net>
On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> I forgot to add a "reg = <0>;" property to the flash@0 node while
> writing the example. Fix this.
Don't be personal in commit messages. Instead:
Add missing "reg = <0>;" property to the flash@0 node in the example.
which has the same amount of information and is even shorter.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-29 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 21:49 [PATCH 0/2] nuvoton,wpcm450-fiu binding example fixes Jonathan Neuschäfer
2022-11-28 21:49 ` [PATCH 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include) Jonathan Neuschäfer
2022-11-29 8:04 ` Krzysztof Kozlowski
2022-11-28 21:49 ` [PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property) Jonathan Neuschäfer
2022-11-29 8:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657e7d50-7352-1a4f-6977-cf1d9c6e6c8e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).