From: Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>
To: Ashish Kumar <ashish.kumar@nxp.com>, Mark Brown <broonie@kernel.org>
Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Varun Sethi <V.Sethi@nxp.com>, Arokia Samy <arokia.samy@nxp.com>,
Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Paul Yang <Paul.Yang@arm.com>
Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
Date: Tue, 15 Sep 2020 12:22:17 +0530 [thread overview]
Message-ID: <6b704e53b0f31a2a74b35e477a330aac@mail.gmail.com> (raw)
In-Reply-To: <HE1PR04MB31961146633F7FE9EFE441A795240@HE1PR04MB3196.eurprd04.prod.outlook.com>
> -----Original Message-----
> From: Ashish Kumar <ashish.kumar@nxp.com>
> Sent: Friday, September 11, 2020 7:03 PM
> To: Mark Brown <broonie@kernel.org>
> Cc: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>; Yogesh Gaur
> <yogeshgaur.83@gmail.com>; linux-spi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Varun Sethi <V.Sethi@nxp.com>; Arokia Samy
> <arokia.samy@nxp.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Samer
El-
> Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Paul Yang
> <Paul.Yang@arm.com>
> Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
>
> Hi Mark,
>
> > -----Original Message-----
> > From: Mark Brown <broonie@kernel.org>
> > Sent: Friday, September 11, 2020 6:04 PM
> > To: Ashish Kumar <ashish.kumar@nxp.com>
> > Cc: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>; Yogesh Gaur
> > <yogeshgaur.83@gmail.com>; linux-spi@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Varun Sethi <V.Sethi@nxp.com>; Arokia Samy
> > <arokia.samy@nxp.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Samer
> > El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Paul Yang
> > <Paul.Yang@arm.com>
> > Subject: Re: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
> >
> > On Fri, Sep 11, 2020 at 12:28:47PM +0000, Ashish Kumar wrote:
> > > > Signed-off-by: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
> >
> > > Please capture version change summary.
> > >
> > > Regards
> > > Ashish
> >
> > It's there:
> It did not mentioned about removing SWRST, which was present in v1.
> v2:Notes Looked very similar to v1.
Removed SWRST changes just to keep functionality same in ACP and DT mode,
I will post that change separately if It will be required. For tracking I
am adding this
point in notes
>
> Regards
> Ashish
> >
> > > >
> > > > Notes:
> > > > 1. Add ACPI match table, NXP members are added to confirm HID
> > > > for
> > FSPI
> > > > 2. Change the DT specific APIs to device property APIs
> > > > so that same API can be used in DT and ACPi mode.
> > > > 3. Omit clock configuration part - in ACPI world, the firmware
> > > > is responsible for clock maintenance.
> > > > 4. This patch is tested on LX2160A platform
5. SWRST reset changes are removed from v1 as to keep functionality
same in ACP and DT mode, I will post that change separately if It will be
required
prev parent reply other threads:[~2020-09-15 6:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 8:28 [PATCH v2] spi: spi-nxp-fspi: Add ACPI support kuldip dwivedi
2020-09-11 11:00 ` Mark Brown
2020-09-11 11:16 ` Ard Biesheuvel
2020-09-11 12:02 ` Kuldip Dwivedi
2020-09-11 12:17 ` Mark Brown
2020-09-11 12:28 ` [EXT] " Ashish Kumar
2020-09-11 12:34 ` Mark Brown
2020-09-11 13:32 ` Ashish Kumar
2020-09-15 6:52 ` Kuldip Dwivedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b704e53b0f31a2a74b35e477a330aac@mail.gmail.com \
--to=kuldip.dwivedi@puresoftware.com \
--cc=Ard.Biesheuvel@arm.com \
--cc=Paul.Yang@arm.com \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=V.Sethi@nxp.com \
--cc=arokia.samy@nxp.com \
--cc=ashish.kumar@nxp.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).