From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C65C433E2 for ; Tue, 15 Sep 2020 06:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1692820829 for ; Tue, 15 Sep 2020 06:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=puresoftware-com.20150623.gappssmtp.com header.i=@puresoftware-com.20150623.gappssmtp.com header.b="zmuyaBNI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726129AbgIOGw1 (ORCPT ); Tue, 15 Sep 2020 02:52:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbgIOGwV (ORCPT ); Tue, 15 Sep 2020 02:52:21 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC76C061788 for ; Mon, 14 Sep 2020 23:52:21 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id n22so1922930edt.4 for ; Mon, 14 Sep 2020 23:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware-com.20150623.gappssmtp.com; s=20150623; h=return-receipt-to:from:references:in-reply-to:mime-version :thread-index:disposition-notification-to:date:message-id:subject:to :cc; bh=WDvIeCQ5RNLVydHGn5T1WfslUcwOnqNb4dwmVb3HxMU=; b=zmuyaBNIhrB7oi9l06e0aMru/WX/PioNxQagCyIKdrkNm8wmGZdUjP409SYG+l44Qq tThAcADZ5COCZShsVpgEx2nHsLXbmexny4YCsUSYt6G1SpgjWrJKQ/OHHRXpvA2FenBb KllvVG+5Y41pONP+0Ykh65TaTyFdtsSkvuegXVKS1gyq23Tz8e8ndlABxVJdhRSahsty KlvQKI7MosiH4nAEGWl/CJpFAhDCItQeP5Meq2fn470R1Jc1HJgHQ6Sg2gvDaj6FBkqz FLBdCvTU2jPkPQwHC8bNO3KVKzgO2AKr4/A5WhKY5BaKKZuWVd55cGq4UMW/tXVVf6b4 icPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:return-receipt-to:from:references:in-reply-to :mime-version:thread-index:disposition-notification-to:date :message-id:subject:to:cc; bh=WDvIeCQ5RNLVydHGn5T1WfslUcwOnqNb4dwmVb3HxMU=; b=XXKVYS7NdDWvGDCJeZSki42hseEz3SOFQ8TNeOLGcRgrHlp8NL8Yj56vMU1CGy99Gz MueqWuSJt63WYX8Je7ZmB63SEw5XC7b60k2tpoZuNHrFKRBYu7Rf+897U3tt3PTdu7jS 7OG4+QEOgVJilyowrIopxyemmU/d//CmGJss1vlMdTwqzc/uqSll04GnmDBurlgoGzSf /7l8odnQ7uCnIVUWlbY+PRsZAwoq89oO4eQBvu9a7gZ0MieZUbyuBt7Ta3CR3Vd3nRQC 8zuJ3N3/1HyFj25h9y1WjMYoDi2fwxttayK0ND5tXUs9/7XA10u1u3n5qL/GW4TlIg11 gzqw== X-Gm-Message-State: AOAM531Zej2V4h8YsGsdkoxGhmJy6aHI3unaOVlicGJFSicExMnalA3v XHk6q40nLIGUzkp82YCgfECdAv9xvgZFK3GXsqBvHQ== X-Google-Smtp-Source: ABdhPJyCxLAW+oKOPWHupiAXoLutdXJP8omET0+rAMsydsmRiqgllVTcfQMxKIM34kf/l0J8IV0ZSw1X9sOH9npj2VA= X-Received: by 2002:a05:6402:b72:: with SMTP id cb18mr20308016edb.299.1600152737411; Mon, 14 Sep 2020 23:52:17 -0700 (PDT) From: Kuldip Dwivedi References: <20200911082806.115-1-kuldip.dwivedi@puresoftware.com> <20200911123428.GF4895@sirena.org.uk> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQK/xI2P7uxCBV5mjF/xjkF3M143zQKAOUTHAVgUksMCVmnJ7KdlWOrw Date: Tue, 15 Sep 2020 12:22:17 +0530 Message-ID: <6b704e53b0f31a2a74b35e477a330aac@mail.gmail.com> Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support To: Ashish Kumar , Mark Brown Cc: Yogesh Gaur , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Varun Sethi , Arokia Samy , Ard Biesheuvel , Samer El-Haj-Mahmoud , Paul Yang Content-Type: text/plain; charset="UTF-8" Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org > -----Original Message----- > From: Ashish Kumar > Sent: Friday, September 11, 2020 7:03 PM > To: Mark Brown > Cc: kuldip dwivedi ; Yogesh Gaur > ; linux-spi@vger.kernel.org; linux- > kernel@vger.kernel.org; Varun Sethi ; Arokia Samy > ; Ard Biesheuvel ; Samer El- > Haj-Mahmoud ; Paul Yang > > Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support > > Hi Mark, > > > -----Original Message----- > > From: Mark Brown > > Sent: Friday, September 11, 2020 6:04 PM > > To: Ashish Kumar > > Cc: kuldip dwivedi ; Yogesh Gaur > > ; linux-spi@vger.kernel.org; linux- > > kernel@vger.kernel.org; Varun Sethi ; Arokia Samy > > ; Ard Biesheuvel ; Samer > > El-Haj-Mahmoud ; Paul Yang > > > > Subject: Re: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support > > > > On Fri, Sep 11, 2020 at 12:28:47PM +0000, Ashish Kumar wrote: > > > > Signed-off-by: kuldip dwivedi > > > > > Please capture version change summary. > > > > > > Regards > > > Ashish > > > > It's there: > It did not mentioned about removing SWRST, which was present in v1. > v2:Notes Looked very similar to v1. Removed SWRST changes just to keep functionality same in ACP and DT mode, I will post that change separately if It will be required. For tracking I am adding this point in notes > > Regards > Ashish > > > > > > > > > > Notes: > > > > 1. Add ACPI match table, NXP members are added to confirm HID > > > > for > > FSPI > > > > 2. Change the DT specific APIs to device property APIs > > > > so that same API can be used in DT and ACPi mode. > > > > 3. Omit clock configuration part - in ACPI world, the firmware > > > > is responsible for clock maintenance. > > > > 4. This patch is tested on LX2160A platform 5. SWRST reset changes are removed from v1 as to keep functionality same in ACP and DT mode, I will post that change separately if It will be required