Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] spi: fsl-dspi: Fix probe info message
Date: Thu, 25 Sep 2014 12:30:58 +0200	[thread overview]
Message-ID: <74325058.MxaXLQJlSp@ws-stein> (raw)
In-Reply-To: <20140925101430.GM16977-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Thursday 25 September 2014 11:14:30, Mark Brown wrote:
> On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote:
> 
> > -	pr_info(KERN_INFO "Freescale DSPI master initialized\n");
> > +	dev_info(&pdev->dev, "master initialized\n");
> 
> This message has no content, it should just be removed entirely.

Well, you know that the device has been probed successfully, which IMO is a message the user should be able to see in dmesg.

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-09-25 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  8:53 [PATCH 1/1] spi: fsl-dspi: Fix probe info message Alexander Stein
     [not found] ` <1411635212-20908-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
2014-09-25 10:14   ` Mark Brown
     [not found]     ` <20140925101430.GM16977-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-25 10:30       ` Alexander Stein [this message]
2014-09-25 11:11         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74325058.MxaXLQJlSp@ws-stein \
    --to=alexander.stein-93q1ybgzjsme9jswtwoym3xstj4p+dsv@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox