From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaewon Kim Subject: Re: [PATCH] spi: dw: fix buffer end address Date: Tue, 30 Oct 2018 01:35:15 +0900 Message-ID: <762bc63e-7b01-0d77-3939-7b236dbda37f@gmail.com> References: <1540395437-6623-1-git-send-email-jaewon02.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=euc-kr; format=flowed Content-Transfer-Encoding: 8bit Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org To: Mark Brown , Jaewon Kim Return-path: In-Reply-To: <1540395437-6623-1-git-send-email-jaewon02.kim@samsung.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org There is some side effect on this patch. So, I revoke this patch. 18. 10. 25. 오전 12:37에 Jaewon Kim 이(가) 쓴 글: > Buffer address can be NULL, if user does not want to receive TX/RX data. > In this case, driver should not set the rx/tx_end value with len. > > Signed-off-by: Jaewon Kim > --- > drivers/spi/spi-dw.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c > index b705f2b..34e6fca 100644 > --- a/drivers/spi/spi-dw.c > +++ b/drivers/spi/spi-dw.c > @@ -293,9 +293,13 @@ static int dw_spi_transfer_one(struct spi_controller *master, > dws->dma_mapped = 0; > > dws->tx = (void *)transfer->tx_buf; > - dws->tx_end = dws->tx + transfer->len; > + dws->tx_end = dws->tx; > + if (dws->tx) > + dws->tx_end += transfer->len; > dws->rx = transfer->rx_buf; > - dws->rx_end = dws->rx + transfer->len; > + dws->rx_end = dws->rx; > + if (dws->rx) > + dws->rx_end += transfer->len; > dws->len = transfer->len; > > spi_enable_chip(dws, 0);