From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A19C54EE9 for ; Thu, 8 Sep 2022 13:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbiIHNma (ORCPT ); Thu, 8 Sep 2022 09:42:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbiIHNm0 (ORCPT ); Thu, 8 Sep 2022 09:42:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D458CE72D2 for ; Thu, 8 Sep 2022 06:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662644545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dY7UGDgAaThf/zGLCo78Nc7H8PVWh9/Q5L5/T8dTqWI=; b=A0GgCA7H/AXlEVrGTJMoQUCuOppeG2suNZSsWesvzZFOe3W+Lj0TJ1x3V8tJGYcxHbIE0Z xLQglFC8/Rzalqnv10NLwioLuE8UGCT3JEnwWht5WtHOsRhelE3C4VGP2/yct1Vbnh/Brr OKq5Q7+xHpwsrCmvVls/R2cmjPKZjSs= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-461-nj6wTVGVMpSF9WYy9r6ZWA-1; Thu, 08 Sep 2022 09:42:19 -0400 X-MC-Unique: nj6wTVGVMpSF9WYy9r6ZWA-1 Received: by mail-ej1-f72.google.com with SMTP id sh44-20020a1709076eac00b00741a01e2aafso6500139ejc.22 for ; Thu, 08 Sep 2022 06:42:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=dY7UGDgAaThf/zGLCo78Nc7H8PVWh9/Q5L5/T8dTqWI=; b=AaSGbsljUnfI3xObl/9hT1PHYpAyNFBu+mnY/9XEhz1sk5eTQ7R16o169mU8deQfp0 d9bygQs3eGZZcD6un9RqYUKDzjBqBVhnAYftRTtsEJ+4ibG5IsCWboWfjEviiSPqBkfS SL/G7l/81g//oZ6v+i1PkLzSzcpbdRKWtcrhaLMjiSTYCnObmjIFKwBJ5E1++DcIyvHg FFkCqK0Tk9X36R6LN9mBGWCu+gF4PxN314mnDK2nwrfrCfkagj89hLpnvktmhDhmj3fk stfyEn3RLwVyuJColxApaGgsk9xbaX3z557mf5MuVs2/XNorz0YBxXcVsC1kZOCS6NjE d5ew== X-Gm-Message-State: ACgBeo2n/3wkjMjhbwybK7XMwlufDAyrqNssKq7C6RZfGSAnKrk3i7+C 9Fzn1rM2HlEy/SiEwo8sOwyOIWx/+TkFOc+qVahmamGLW96KUTfpwXV/r/nFPIeovOOWcELX6iP ZwI9jp82Cy5ShdXJVlXqY X-Received: by 2002:a17:907:96a3:b0:740:a894:f with SMTP id hd35-20020a17090796a300b00740a894000fmr6136622ejc.460.1662644538489; Thu, 08 Sep 2022 06:42:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR5AC4iFP8kH6lKh83PspsOpkpVkUS6JN8xBfUD/yEuKwkju+iQLnwP+Y88hQIIWETucCSz8UQ== X-Received: by 2002:a17:907:96a3:b0:740:a894:f with SMTP id hd35-20020a17090796a300b00740a894000fmr6136591ejc.460.1662644538255; Thu, 08 Sep 2022 06:42:18 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id bm9-20020a0564020b0900b0044ec76521a1sm5837844edb.55.2022.09.08.06.42.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 06:42:17 -0700 (PDT) Message-ID: <767b4c6c-c860-b490-4e85-34c6677de456@redhat.com> Date: Thu, 8 Sep 2022 15:42:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer() To: Andy Shevchenko , "Rafael J. Wysocki" , Ard Biesheuvel , Mark Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devel@acpica.org Cc: "Rafael J. Wysocki" , Len Brown , Elie Morisse , Nehal Shah , Shyam Sundar S K , Khalil Blaiech , Andy Gross , Bjorn Andersson , Konrad Dybcio , Will Deacon , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Robert Moore , Wolfram Sang References: <20220908132910.62122-1-andriy.shevchenko@linux.intel.com> <20220908132910.62122-9-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20220908132910.62122-9-andriy.shevchenko@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi, On 9/8/22 15:29, Andy Shevchenko wrote: > ACPI utils provide acpi_dev_uid_to_integer() helper to extract _UID as > an integer. Use it instead of custom approach. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Ard Biesheuvel Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/firmware/efi/dev-path-parser.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/efi/dev-path-parser.c b/drivers/firmware/efi/dev-path-parser.c > index eb9c65f97841..f80d87c199c3 100644 > --- a/drivers/firmware/efi/dev-path-parser.c > +++ b/drivers/firmware/efi/dev-path-parser.c > @@ -15,9 +15,11 @@ > static long __init parse_acpi_path(const struct efi_dev_path *node, > struct device *parent, struct device **child) > { > - char hid[ACPI_ID_LEN], uid[11]; /* UINT_MAX + null byte */ > struct acpi_device *adev; > struct device *phys_dev; > + char hid[ACPI_ID_LEN]; > + u64 uid; > + int ret; > > if (node->header.length != 12) > return -EINVAL; > @@ -27,12 +29,12 @@ static long __init parse_acpi_path(const struct efi_dev_path *node, > 'A' + ((node->acpi.hid >> 5) & 0x1f) - 1, > 'A' + ((node->acpi.hid >> 0) & 0x1f) - 1, > node->acpi.hid >> 16); > - sprintf(uid, "%u", node->acpi.uid); > > for_each_acpi_dev_match(adev, hid, NULL, -1) { > - if (adev->pnp.unique_id && !strcmp(adev->pnp.unique_id, uid)) > + ret = acpi_dev_uid_to_integer(adev, &uid); > + if (ret == 0 && node->acpi.uid == uid) > break; > - if (!adev->pnp.unique_id && node->acpi.uid == 0) > + if (ret == -ENODATA && node->acpi.uid == 0) > break; > } > if (!adev)