From: "Nuno Sá" <noname.nuno@gmail.com>
To: Mark Brown <broonie@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: linux-spi@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH 1/4] spi: xcomm: add gpiochip support
Date: Thu, 04 Jul 2024 16:00:15 +0200 [thread overview]
Message-ID: <76970371e32a30b774fd6d12fc38e8355d950ca7.camel@gmail.com> (raw)
In-Reply-To: <3ca36d0d-581c-4e24-9466-fb30a3a22d71@sirena.org.uk>
On Thu, 2024-07-04 at 14:53 +0100, Mark Brown wrote:
> On Thu, Jul 04, 2024 at 03:49:12PM +0200, Nuno Sa wrote:
>
> > +static int spi_xcomm_gpio_get_value(struct gpio_chip *chip, unsigned int
> > offset)
> > +{
> > + struct spi_xcomm *spi_xcomm = gpiochip_get_data(chip);
> > +
> > + return spi_xcomm->gpio_val;
> > +}
>
> It seems like the hardware doesn't support input at all so should there
> even be a get operation? gpiolib appears to cope fine with omitting it.
Just following recommendations :)
https://elixir.bootlin.com/linux/v6.10-rc6/source/include/linux/gpio/driver.h#L336
- Nuno Sá
next prev parent reply other threads:[~2024-07-04 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 13:49 [PATCH 0/4] spi: xcomm: support GPO pin Nuno Sa
2024-07-04 13:49 ` [PATCH 1/4] spi: xcomm: add gpiochip support Nuno Sa
2024-07-04 13:53 ` Mark Brown
2024-07-04 14:00 ` Nuno Sá [this message]
2024-07-04 15:45 ` Mark Brown
2024-07-05 9:13 ` Nuno Sá
2024-07-04 13:49 ` [PATCH 2/4] spi: xcomm: make use of devm_spi_alloc_host() Nuno Sa
2024-07-04 13:49 ` [PATCH 3/4] spi: xcomm: remove i2c_set_clientdata() Nuno Sa
2024-07-04 13:49 ` [PATCH 4/4] spi: xcomm: fix coding style Nuno Sa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76970371e32a30b774fd6d12fc38e8355d950ca7.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).