From: Stefan Wahren <stefan.wahren@i2se.com>
To: kernel@martin.sperl.org, Mark Brown <broonie@kernel.org>,
Eric Anholt <eric@anholt.net>,
Hubert Denkmair <h.denkmair@intence.de>,
linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 0/9] spi: bcm2835aux: bug fixes and improvements
Date: Tue, 2 Apr 2019 19:03:34 +0200 (CEST) [thread overview]
Message-ID: <772240203.376689.1554224614445@email.ionos.de> (raw)
In-Reply-To: <20190330093106.20723-1-kernel@martin.sperl.org>
> kernel@martin.sperl.org hat am 30. März 2019 um 10:30 geschrieben:
>
>
> From: Martin Sperl <kernel@martin.sperl.org>
>
> Set of patches improving the spi-bcm2835aux driver and fixing
> a data read corruption bug.
>
> The main motivation is a rare data corruption fix that is mostly
> observed in polling mode first reported by Hubert Denkmair.
>
> So this patchset first implements a means to control the parameters
> of when polling mode is used via module parameters and exports
> the corresponding statistics.
>
> As stated in original patch the driver does not support native CS.
> But when cs-gpios is not configured in the dt (so a buggy dt) it is
> still working with a lot of limitations, but the driver does not report
> this fact.
>
> So this patchset adds reporting and allows for a single native CS
> (with limited functionality) to continue working with a buggy DT.
> One question here remains: do we need to legacy support DTs
> that are not following specs in the first place?
>
> Then there is the real fix for the data-corruption which is split
> into 3 parts: some code cleanup with code reuse, removing "dangerous"
> fifo read (possibly introducing fifo data corruption) and safe fifo read.
>
> Also we remove some dead code.
>
> ---
> Changelog:
> V1 -> V2: reordering commits as per request of Stefan Wahren
> to help backporting the "essential" bugfixes go in first
> remove the dependency on a different patchset focused on
> making cs_change delay configurable
> V2 -> V3: incorporated feedback by Stefan Wahren
The whole series is:
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-02 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 9:30 [PATCH V3 0/9] spi: bcm2835aux: bug fixes and improvements kernel
[not found] ` <20190330093106.20723-1-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2019-03-30 9:30 ` [PATCH V3 1/9] spi: bcm2835aux: unifying code between polling and interrupt driven code kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 9:30 ` [PATCH V3 2/9] spi: bcm2835aux: remove dangerous uncontrolled read of fifo kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 9:31 ` [PATCH V3 3/9] spi: bcm2835aux: fix corruptions for longer spi transfers kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 9:31 ` [PATCH V3 4/9] spi: bcm2835aux: remove dead code kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 9:31 ` [PATCH V3 5/9] spi: bcm2835aux: fix driver to not allow 65535 (=-1) cs-gpios kernel-TqfNSX0MhmxHKSADF0wUEw
2019-04-03 4:32 ` Mark Brown
2019-03-30 9:31 ` [PATCH V3 6/9] spi: bcm2835aux: warn in dmesg that native cs is not really supported kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 9:31 ` [PATCH V3 7/9] spi: bcm2835aux: setup gpio-cs to output and correct level during setup kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 9:31 ` [PATCH V3 9/9] spi: bcm2835aux: make the polling duration limits configurable kernel-TqfNSX0MhmxHKSADF0wUEw
2019-03-30 10:13 ` [PATCH V3 8/9] spi: bcm2835aux: add driver stats to debugfs kernel
2019-04-02 17:03 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=772240203.376689.1554224614445@email.ionos.de \
--to=stefan.wahren@i2se.com \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=h.denkmair@intence.de \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).