From: Mark Brown <broonie@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] spi: axi-spi-engine: fix missing bitfield include
Date: Fri, 7 Feb 2025 13:36:07 +0000 [thread overview]
Message-ID: <7b45b00a-a070-452a-9560-168e5585ac11@sirena.org.uk> (raw)
In-Reply-To: <20250206215513.2842270-1-dlechner@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Thu, Feb 06, 2025 at 03:55:13PM -0600, David Lechner wrote:
> Fix missing linux/bitfield.h include needed for FIELD_GET macro.
This doesn't apply against current code, please check and resend.
> I know you prefer patches like this to fix something in a patch that has
> already been applied, but it doesn't look like you actually picked up the
> offending commit[1] yet in your main tree, so I don't have a commit hash
> for a proper Fixes: tag.
> Do you want a fix like this or should I send a v8 with the fix squashed?
> [1]: https://lore.kernel.org/linux-spi/20250113-dlech-mainline-spi-engine-offload-2-v7-7-e0860c81caae@baylibre.com/
I haven't applied that because of all the build issues that the bots
reported, you need to send a new version that build cleanly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-02-07 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 21:55 [PATCH] spi: axi-spi-engine: fix missing bitfield include David Lechner
2025-02-07 13:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b45b00a-a070-452a-9560-168e5585ac11@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox