From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prajna.Rajendrakumar@microchip.com, broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org,
Conor.Dooley@microchip.com, devicetree@vger.kernel.org,
robh@kernel.org, linux-kernel@vger.kernel.org,
krzk+dt@kernel.org, Valentina.FernandezAlanis@microchip.com,
Daire.McNamara@microchip.com
Subject: Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi
Date: Fri, 3 May 2024 16:46:13 +0200 [thread overview]
Message-ID: <7b6489b7-ec9f-4fc7-af72-4d5cc87acd7f@kernel.org> (raw)
In-Reply-To: <1edb6c4c1a66c1a2009278b99f897e3a71b592c6.camel@microchip.com>
On 03/05/2024 14:54, Prajna.Rajendrakumar@microchip.com wrote:
>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: microchip,mpfs-spi
>>> + not:
>>> + required:
>>> + - cs-gpios
>>
>> I don't understand what you are expressing here. Did you actually
>> validate it that it achieves exactly what you want?
>
> Since the controller supports only one chip select, the num-cs should
> default to 1 and cannot exceed 1 unless GPIOs are used as chip selects.
That's not really the answer... or you want to say you did not test it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-03 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:34 [PATCH 0/3] Add support for GPIO based CS Prajna Rajendra Kumar
2024-05-02 14:34 ` [PATCH 1/3] spi: spi-microchip-core: " Prajna Rajendra Kumar
2024-05-02 15:54 ` Conor Dooley
2024-05-03 5:27 ` kernel test robot
2024-05-03 5:37 ` kernel test robot
2024-05-02 14:34 ` [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi Prajna Rajendra Kumar
2024-05-02 14:53 ` Krzysztof Kozlowski
2024-05-03 12:54 ` Prajna.Rajendrakumar
2024-05-03 14:46 ` Krzysztof Kozlowski [this message]
2024-05-03 16:11 ` Conor Dooley
2024-05-07 7:57 ` Prajna.Rajendrakumar
2024-05-03 10:40 ` Conor Dooley
2024-05-02 14:34 ` [PATCH 3/3] spi: spi-microchip-core: Fix the number of chip selects supported Prajna Rajendra Kumar
2024-05-02 15:47 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b6489b7-ec9f-4fc7-af72-4d5cc87acd7f@kernel.org \
--to=krzk@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Prajna.Rajendrakumar@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).