From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EA2EB64D9 for ; Mon, 19 Jun 2023 12:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbjFSMUS (ORCPT ); Mon, 19 Jun 2023 08:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230407AbjFSMUR (ORCPT ); Mon, 19 Jun 2023 08:20:17 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E570E74 for ; Mon, 19 Jun 2023 05:20:15 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5195c85fbb2so4348575a12.2 for ; Mon, 19 Jun 2023 05:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687177214; x=1689769214; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r8IkgjCbYZ6ybcsI1GkHhRXG+M118R7BE1wtTAsnJr8=; b=ClBnqG9Gjo9yzp03JC2sB9Tl5OykGEG0MCJfr1gRTiPcMlb2sUa63W1A/h/3FcWLZ6 Oy+I69ZWHgkwChDAddgOpSJnOFM9+abTF6e1r5FBj+O42kaBoGYG0U0mC7k920HYfGIF FAQh/w9ifmvIm7waigd8Lj1Y4DeFo1UeUkH8y2Lgf0RZYTSMy9fabS9jneySUICduSAY wMB/lz9ssGuuLUzSwZuB8bSDc+sZMiRDCHVvS3SSpsbJYgUQkDKp5xuBM7QUy0586W4B sy3v8JwtknzXVgYmQgfnckuUpNmuLUpsd+2aCcn03JLheYs9kqu0H6wjdMY2qpPD1A24 +J1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687177214; x=1689769214; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r8IkgjCbYZ6ybcsI1GkHhRXG+M118R7BE1wtTAsnJr8=; b=AdJ7oMEPn/+XQOA0xaMrfpFajBrnzb2XjsFsTNOqESY5WGGoi+nIAzLymPxBQE+G2+ ZcxT/BSTXKtb77cJUs7gasuBWh7I4eN18gpjpjd5GGCptEAPeHZecdN+0duH+wjOswFr fiNXiRZy7mKaDB46l/j3uO6pDME5Kk1vWDY4fM/CllWGemqNY2TRlXCiaYSzDhqtyHhy PIrdCzfWZCiFymwvXVuIp6tnnBZpMg80FtyUe+7f4tsxvWL95tFjmdCkFOj8DNYJB45l ETBudvfvQXxua+XxwtxmWY+UrIcWCfSO3x4KgkEaNO9Omm+tJpnIOaphF6O28gdnAl9j HlMg== X-Gm-Message-State: AC+VfDyeRA/i42U4h8hfGpNV3kDM+a++5w17ov5sZxUia1e/36YHZ9FV lRLOx7jNAzSh90c+UBor31t3Yg== X-Google-Smtp-Source: ACHHUZ47zEpJ6DeZD7uVxLdbu7k9xsdXjPX7y1tBu5kP3TPtRM2Jk60R/mDNGae7578PNVPH21KORg== X-Received: by 2002:a17:907:7d86:b0:978:8790:9103 with SMTP id oz6-20020a1709077d8600b0097887909103mr9499787ejc.70.1687177214016; Mon, 19 Jun 2023 05:20:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id c21-20020a170906341500b00985bdb7dd5fsm4805480ejb.201.2023.06.19.05.20.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 05:20:13 -0700 (PDT) Message-ID: <7b7694da-8b40-d76a-adca-4cf9aa206ff4@linaro.org> Date: Mon, 19 Jun 2023 14:20:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 3/3] riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC Content-Language: en-US To: William Qiu , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Ziv Xu References: <20230619083517.415597-1-william.qiu@starfivetech.com> <20230619083517.415597-4-william.qiu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230619083517.415597-4-william.qiu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 19/06/2023 10:35, William Qiu wrote: > Add the quad spi controller node for the StarFive JH7110 SoC. > > Co-developed-by: Ziv Xu > Signed-off-by: Ziv Xu > Signed-off-by: William Qiu > Reviewed-by: Hal Feng > --- > .../jh7110-starfive-visionfive-2.dtsi | 32 +++++++++++++++++++ > arch/riscv/boot/dts/starfive/jh7110.dtsi | 18 +++++++++++ > 2 files changed, 50 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > index 2a6d81609284..22212c1150f9 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > @@ -126,6 +126,38 @@ &i2c6 { > status = "okay"; > }; > > +&qspi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + nor_flash: flash@0 { > + compatible = "jedec,spi-nor"; > + reg=<0>; Missing spaces. > + cdns,read-delay = <5>; > + spi-max-frequency = <12000000>; > + cdns,tshsl-ns = <1>; > + cdns,tsd2d-ns = <1>; > + cdns,tchsh-ns = <1>; > + cdns,tslch-ns = <1>; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + spl@0 { > + reg = <0x0 0x20000>; > + }; > + uboot@100000 { > + reg = <0x100000 0x300000>; > + }; > + data@f00000 { > + reg = <0xf00000 0x100000>; > + }; > + }; > + }; > +}; > + > &sysgpio { > i2c0_pins: i2c0-0 { > i2c-pins { > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi > index 4c5fdb905da8..0b24f9e66e67 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi > @@ -440,6 +440,24 @@ i2c6: i2c@12060000 { > status = "disabled"; > }; > > + qspi: spi@13010000 { > + compatible = "starfive,jh7110-qspi", "cdns,qspi-nor"; > + reg = <0x0 0x13010000 0x0 0x10000 > + 0x0 0x21000000 0x0 0x400000>; This should be two items so <>, <>. Not one item. Best regards, Krzysztof