From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07428C433ED for ; Fri, 23 Apr 2021 17:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB45C6124B for ; Fri, 23 Apr 2021 17:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243274AbhDWRe4 (ORCPT ); Fri, 23 Apr 2021 13:34:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44692 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231400AbhDWRe4 (ORCPT ); Fri, 23 Apr 2021 13:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619199259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ktUbwIWTJ14trqUM1JPFPbDz0iRRWU7hILTLbA82a8=; b=GgfTu/lEqR9G9wmTQ2YZajxZTcDQ79V6d4/AEzrT4Ux76DcZ8L5VZAv6XxcpECnZZeZavo lm6Zq4EFQLNAE2XMk3EFzhz0GnBmzZsoTO5UzHqjK1uFTF2fhoxjhT047mAKuYULE9f4Ed 0iqWHB8zipAp87wap8U4G8uATyGFQ0M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-KuO-YM7UMsmC-tCGBGJFlg-1; Fri, 23 Apr 2021 13:34:17 -0400 X-MC-Unique: KuO-YM7UMsmC-tCGBGJFlg-1 Received: by mail-wm1-f72.google.com with SMTP id u11-20020a05600c00cbb029012a3f52677dso7082027wmm.8 for ; Fri, 23 Apr 2021 10:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=2ktUbwIWTJ14trqUM1JPFPbDz0iRRWU7hILTLbA82a8=; b=qVyihu2LdxR3rGj81juL61YFhSmYnfp0zSn2t2OyBQEyoVjo4MOCcEM0ftRXm6B0T0 w1Z4fVMtMxdbEE5UB7q8fy1X/v4hIQBirT2IBOFNoKq3FICLaqFhchm6DWbVu1fWKr4t 5gha/LR59d0WFbbZTs7hwQ22yLPEowrBP6pHZwgILzmlcNWkgrqWl+55qrB18MTXgIpr ZwM/60kMeHkwWl1qcElp8D5ao5MUXZjThRuBg0Xxkyqb9d2LVZFvMapQqgxbvZvKkpq1 TGxL5E3omjIXicuiOOfn7hTGrr1TLE2+Z+Qo0G7aSwHgCH/idip1qzJSjkt01v0iF7bK Qj+g== X-Gm-Message-State: AOAM530/VmiZvFZ6ICDlHk5R+4OwYj7Ei6WNXySXG0RCEMNIJeUZtELl Kz2PHx7EKnY2ilVwpzk2LBsDzlffWYoBezWVcXmEnpVOKKYoTsqX1jBvYixp2tN2yu17nmuR2FZ 3WKtktFSrnsGD9XwO/Z+G X-Received: by 2002:a7b:c8ce:: with SMTP id f14mr6555913wml.113.1619199256170; Fri, 23 Apr 2021 10:34:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyh+EjNZzglFda5j+WRJWaTK/VWXhlD03BlaQaBpPs6h5L2iYZBz1lgQWscsMuEMh4laCiLXg== X-Received: by 2002:a7b:c8ce:: with SMTP id f14mr6555895wml.113.1619199256037; Fri, 23 Apr 2021 10:34:16 -0700 (PDT) Received: from ?IPv6:2a0c:5a80:3108:4700:8d94:f633:2343:f95c? ([2a0c:5a80:3108:4700:8d94:f633:2343:f95c]) by smtp.gmail.com with ESMTPSA id o17sm7767902wmq.47.2021.04.23.10.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 10:34:15 -0700 (PDT) Message-ID: <84cafe48637fd1deed7da2cd15eb2f7679545416.camel@redhat.com> Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. From: Nicolas Saenz Julienne To: Mark Brown , Joe Burmeister Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 23 Apr 2021 19:34:14 +0200 In-Reply-To: <20210423162055.GE5507@sirena.org.uk> References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> <271ad212-a606-620e-3f0c-d6bff272be3c@gmail.com> <380624c4-82f3-0e6e-8cdb-8a9732636db8@devtank.co.uk> <20210423115724.GB5507@sirena.org.uk> <672e8d77-ee5c-f10f-0bd3-f8708dfc24c8@devtank.co.uk> <20210423162055.GE5507@sirena.org.uk> User-Agent: Evolution 3.40.0 (3.40.0-1.fc34) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=nsaenzju@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, 2021-04-23 at 17:20 +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 03:12:11PM +0100, Joe Burmeister wrote: > > Of course we could just raise BCM2835_SPI_NUM_CS to 8 or more if that is > > preferred. Does seams like the dynamic solution is less favoured. > > The best thing would be to have it not have a single array of chip > select specific data and instead store everything in the controller_data > that's there per-device. +1 All in all, it would make for a cleaner driver. -- Nicolás Sáenz