From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82607C77B7C for ; Fri, 12 May 2023 15:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241441AbjELPKT (ORCPT ); Fri, 12 May 2023 11:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241757AbjELPKQ (ORCPT ); Fri, 12 May 2023 11:10:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF3C7A24C; Fri, 12 May 2023 08:10:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52DF9656FE; Fri, 12 May 2023 15:10:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F35C433D2; Fri, 12 May 2023 15:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683904208; bh=/hz3ta5XNZof/0N79CR5zsvKkh88g9PLrKTXJa4XIk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PHwNktIXeV485y4Q6NXqGz7qmUq7ZRMt7NSTDDXli5K2EmI5yfp+NhEJ+LG6pCs3w qabAqsKFj3eyHyrp4fhKIkeFHse5HHYGuzMQJdDePP0XZJXc/Cc/a1DAu9BgXbKmoF v0uR5x7maspQHEckuNVIfZgD1hMgX30Y+WSHk/5TamwHbZxenUOuxFthsg6f54vULL rDmARMZZFNIl33D5G9SazuYMePAO12EdzXJO4YuwZb6V3Ap37hk6weSOUacNNUYfwX m4lYoh+myCNF7U+Km0Q/mJGSkrOx+S1IpDTwdiFCqsasvQltCGEJyIUk9VMsSnfBlD //DJpIA0F8pLQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pxUPG-00EbFV-1B; Fri, 12 May 2023 16:10:06 +0100 Date: Fri, 12 May 2023 16:10:05 +0100 Message-ID: <86o7mpmvqq.wl-maz@kernel.org> From: Marc Zyngier To: Charles Keepax Cc: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 07/10] irqchip/cs42l43: Add support for the cs42l43 IRQs In-Reply-To: <20230512122838.243002-8-ckeepax@opensource.cirrus.com> References: <20230512122838.243002-1-ckeepax@opensource.cirrus.com> <20230512122838.243002-8-ckeepax@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ckeepax@opensource.cirrus.com, broonie@kernel.org, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, tglx@linutronix.de, linus.walleij@linaro.org, vkoul@kernel.org, lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, 12 May 2023 13:28:35 +0100, Charles Keepax wrote: > > The CS42L43 is an audio CODEC with integrated MIPI SoundWire interface > (Version 1.2.1 compliant), I2C, SPI, and I2S/TDM interfaces designed > for portable applications. It provides a high dynamic range, stereo > DAC for headphone output, two integrated Class D amplifiers for > loudspeakers, and two ADCs for wired headset microphone input or > stereo line input. PDM inputs are provided for digital microphones. > > The IRQ chip provides IRQ functionality both to other parts of the > cs42l43 device and to external devices that wish to use its IRQs. Sorry, but this isn't much of an interrupt controller driver. A modern interrupt controller driver is firmware-driven (DT or ACPI, pick your poison), uses irq domains, and uses the irqchip API. This is just a another variant of the board-file theme, which has nothing to do with the irqchip subsystem. M. -- Without deviation from the norm, progress is not possible.