From: Kevin Hilman <khilman@deeprootsystems.com>
To: Gregory CLEMENT <gclement00@gmail.com>
Cc: spi-devel-general <spi-devel-general@lists.sourceforge.net>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/2] Put OMAP2 SPI CS in unactive state when return from suspend
Date: Wed, 11 Aug 2010 11:21:58 -0700 [thread overview]
Message-ID: <871va52ent.fsf@deeprootsystems.com> (raw)
In-Reply-To: <AANLkTin7-ZqFRH4GXT4aUfQ4sE=8Jc=3i0j8rTH7EyBm@mail.gmail.com> (Gregory CLEMENT's message of "Wed, 11 Aug 2010 16:42:52 +0200")
Gregory CLEMENT <gclement00@gmail.com> writes:
> We notice that when system wake up from OFF mode, then CS is in
> unactive state until the first SPI transfert.
> For our design it lead to some conflict on this I/O.
> Unactive state for CS when there is no transfert shoudl be the correct
> behaviour: this is the purpose of these patches.
This approach handles an off-mode transition during suspend, but if
off-mode is enabled, you can also have an off-mode transition during
idle.
Since you didn't describe what the conflicts you're seeing are, I would
assume that you'll have the same problems in idle as in suspend, and
this series doesn't address the idle case.
Kevin
> Gregory CLEMENT (2):
> spi: Add hook on suspend/resume for spi master
> spi/omap2_mcspi: When SPI wake up from OFF mode, CS is in wrong
> state: force it to unactive state
>
> drivers/spi/omap2_mcspi.c | 11 ++++++++++-
> drivers/spi/spi.c | 15 ++++++++++++++-
> include/linux/spi/spi.h | 4 +++-
> 3 files changed, 27 insertions(+), 3 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-11 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 14:42 [PATCH 0/2] Put OMAP2 SPI CS in unactive state when return from suspend Gregory CLEMENT
2010-08-11 18:21 ` Kevin Hilman [this message]
[not found] ` <871va52ent.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-08-12 8:43 ` Gregory CLEMENT
2010-08-12 8:54 ` Gregory CLEMENT
2010-08-12 14:28 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871va52ent.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=gclement00@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).