Re: [PATCH v5 3/7] include: linux: move adi-axi-common.h out of fpga

["Nuno Sá" <noname.nuno@gmail.com>]

On Mon, 2025-05-12 at 10:15 -0500, David Lechner wrote:
> On 5/12/25 9:46 AM, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> > 
> > The adi-axi-common.h header has some common defines used in various ADI
> > IPs. However they are not specific for any fpga manager so it's
> > questionable for the header to live under include/linux/fpga. Hence
> > let's just move one directory up and update all users.
> > 
> > Suggested-by: Xu Yilun <yilun.xu@linux.intel.com>
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for IIO
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> >  drivers/clk/clk-axi-clkgen.c              | 2 ++
> >  drivers/dma/dma-axi-dmac.c                | 2 +-
> >  drivers/hwmon/axi-fan-control.c           | 2 +-
> >  drivers/iio/adc/adi-axi-adc.c             | 3 +--
> >  drivers/iio/dac/adi-axi-dac.c             | 2 +-
> >  drivers/pwm/pwm-axi-pwmgen.c              | 2 +-
> >  drivers/spi/spi-axi-spi-engine.c          | 2 +-
> >  include/linux/{fpga => }/adi-axi-common.h | 0
> >  8 files changed, 8 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/clk/clk-axi-clkgen.c b/drivers/clk/clk-axi-clkgen.c
> > index
> > 2a95f9b220234a1245024a821c50e1eb9c104ac9..31915f8f5565f2ef5d17c0b4a0c91a648005b3e
> > 6 100644
> > --- a/drivers/clk/clk-axi-clkgen.c
> > +++ b/drivers/clk/clk-axi-clkgen.c
> > @@ -16,6 +16,8 @@
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/err.h>
> >  
> > +#include <linux/adi-axi-common.h>
> > +
> 
> This one is adding, not changing. Was it supposed to be in a later patch?

Oh, indeed... This was "bot mode"...

- Nuno Sá
> 
> >  #define AXI_CLKGEN_V2_REG_RESET		0x40
> >  #define AXI_CLKGEN_V2_REG_CLKSEL	0x44
> >  #define AXI_CLKGEN_V2_REG_DRP_CNTRL	0x70