From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71EAF25948E; Mon, 30 Dec 2024 08:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735548419; cv=none; b=J1nrSb8VB+8qctcckUI0mYahzU/Es3+KW5yJTBBp2KAqvu7Dr9dTG378ZSzFFiz56nz6849lSfREOmmuRZeodq7yzVQt5jk6gOS9uO0r97fOF/alKzu04ZFStzInVnZjAtbfkq/qnjpoMaRIbHXT8i1Q8wmhRw8UMUlWh3Ct6Ig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735548419; c=relaxed/simple; bh=5qCsLO7/DPq0fAwnmdxvog17EUVkdcDvufsuKKDDU44=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HUPVlPdka+b6H/G8tTctmNiBKt3PnVbB6I7nIkOkN0pmStxYssDthEMyWSSw90YQClHTDnVfZWFCWknnSB02bE2jxj6rUfB2dh6U+97lcWWNndVkjkxkG/PFF4DM449V2D1THsAVWGXrUi2FVs47rpKd12x62gx7h/6xEI6z9PI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=V2WVMabC; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="V2WVMabC" Received: by mail.gandi.net (Postfix) with ESMTPSA id 1E2C11C0006; Mon, 30 Dec 2024 08:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1735548414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5qCsLO7/DPq0fAwnmdxvog17EUVkdcDvufsuKKDDU44=; b=V2WVMabCR3tv3DYkj8ceVupPJhyavl3qhgOPs/I9FnR1jKneit/XiPGS4Oc3CUJ4NxgIDa pLsgJlKUNCJfA515f2cbXKr4alkKR+evB+Nhem5PI6cI4VnnEOcC/HAK8JCJ1JdAfzJmTe 6dgsWTL9OpD5zUqe/8e95WW3QQ4Tp+4lMXZeQE2S90e4/GkcOWocy7y7wQ5JbxsZYJxu3k 9l1OiSjR1bbhRB8hcCLOCEgC5RZ0vKiojIFwD8vKUgqnyFwFYK6QTPAFa7ivLgOObUwIZw 2bJ9jpIfno95cevOBvtX5QOOsUSJQh9z8xuE9lsVYdYaV2AwFpnAnxqv/vl/Qg== From: Miquel Raynal To: Raphael Gallais-Pou Cc: Patrice Chotard , Thinh Nguyen , Greg Kroah-Hartman , Adrian Hunter , Ulf Hansson , Richard Weinberger , Vignesh Raghavendra , Damien Le Moal , Niklas Cassel , Alexandre Torgue , Jose Abreu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-ide@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-spi@vger.kernel.org Subject: Re: [PATCH 3/6] mtd: st_spi_fsm: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() In-Reply-To: <20241229-update_pm_macro-v1-3-c7d4c4856336@gmail.com> (Raphael Gallais-Pou's message of "Sun, 29 Dec 2024 00:32:42 +0100") References: <20241229-update_pm_macro-v1-0-c7d4c4856336@gmail.com> <20241229-update_pm_macro-v1-3-c7d4c4856336@gmail.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 30 Dec 2024 09:46:52 +0100 Message-ID: <877c7ha77n.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hello Raphael, On 29/12/2024 at 00:32:42 +01, Raphael Gallais-Pou = wrote: > Letting the compiler remove these functions when the kernel is built > without CONFIG_PM_SLEEP support is simpler and less error prone than the > use of #ifdef based kernel configuration guards. If that does not lead to any warning, I'm fine. However this kind of change is better received subsystem-wide than platform-wide, if you ever wish to go this route. > Link: https://lore.kernel.org/all/20240716180010.126987-1-rgallaispou@gma= il.com This link however seems irrelevant. > Signed-off-by: Raphael Gallais-Pou Thanks, Miqu=C3=A8l