From: Esben Haabendal <esben.haabendal@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe
Date: Thu, 21 Jun 2018 17:27:49 +0200 [thread overview]
Message-ID: <878t78i2h6.fsf@gmail.com> (raw)
In-Reply-To: <20180621132209.GA27215@embeddedor.com> (Gustavo A. R. Silva's message of "Thu, 21 Jun 2018 08:22:09 -0500")
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> It seems that the proper structure field to use in this particular
> case is *regmap_pushr* instead of regmap.
>
> Addresses-Coverity-ID: 1470126 ("Copy-paste error")
> Fixes: 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/spi/spi-fsl-dspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 1f85dcd..ff7456b 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
> dev_err(&pdev->dev,
> "failed to init pushr regmap: %ld\n",
> PTR_ERR(dspi->regmap_pushr));
> - ret = PTR_ERR(dspi->regmap);
> + ret = PTR_ERR(dspi->regmap_pushr);
> goto out_master_put;
> }
> }
Acked-by: Esben Haabendal <eha@deif.com>
prev parent reply other threads:[~2018-06-21 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 13:22 [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe Gustavo A. R. Silva
2018-06-21 15:27 ` Esben Haabendal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t78i2h6.fsf@gmail.com \
--to=esben.haabendal@gmail.com \
--cc=broonie@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).